Authorize MCP Skills extension requests - #6512
Open
JAORMX wants to merge 1 commit into
Open
Conversation
JAORMX
requested review from
ChrisJBurns,
amirejaz,
blkt,
jhrozek,
rdimitrov and
tgrunnagle
as code owners
September 4, 2026 12:53
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6512 +/- ##
==========================================
- Coverage 78.32% 78.27% -0.05%
==========================================
Files 770 770
Lines 75456 75557 +101
==========================================
+ Hits 59101 59143 +42
- Misses 16350 16409 +59
Partials 5 5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/getto CedarAction::"get_skill"/Skill::<exact URI>and filterskills/listentries by that same permission.resources/readauthorization.Type of change
Test plan
task test) — attempted withTMPDIR="$PWD/.tmp" task test; the full race suite failed in unrelated existing tests:pkg/client.TestDetectProjectRoot,pkg/server/discovery.TestCheckHealth_UnixSocket_Success, and the 10-minute timeout inpkg/transport.TestBridge_ToolsListChanged_TriggersReSync.task test-e2e)TMPDIR="$PWD/.tmp" task lint-fix)skills/get,skills/listresponse filtering, malformed/duplicate URI rejection, and SSE error substitution; automated regressions cover each path.Changes
pkg/mcp,pkg/authzget_skillpolicy mapping.docs/authz.mdDoes this introduce a user-facing change?
Yes. Operators can now write
get_skillpolicies for direct-proxied MCP servers that negotiate SEP-2640. Askills/listresponse exposes only the skills the caller may get; reading its files still requires the existing resource-read permission.Implementation plan
Approved implementation plan
skillauthorization feature and parseskills/getby its literal URI.skills/getto an exact CedarSkillentity and admission-check invalid/ambiguous identifiers before dispatch.skills/listbut filter every entry through the sameget_skillpermission; fail closed on unsafe response shapes.Deferred: vMCP aggregation/routing, content-integrity verification, consent records, host materialization, dynamic Skills, and
resources/directory/read.Special notes for reviewers
This deliberately implements only the direct-proxy authorization seam. ToolHive does not advertise, fabricate, or rewrite the Skills extension; client and backend capability negotiation remains end-to-end. The full unit suite currently has unrelated failures noted above.