This repository was archived by the owner on Dec 4, 2024. It is now read-only.
Adding signer product requirements - #69
Open
andrerserrano wants to merge 1 commit into
Open
andrerserrano wants to merge 1 commit into
andrerserrano wants to merge 1 commit into
Conversation
Signed-off-by: Andre Serrano <andre@resident.stacks.org>
netrome
suggested changes
Aug 22, 2023
netrome
left a comment
Contributor
There was a problem hiding this comment.
Although I like the idea of moving more information to these docs, I'm not sure if this document would make sense for a reader who is not already involved in the project.
We should either provide more context around the document, to explain what the signer SDK is and who these requirements are directed at. Optionally, we could create an appendix section in SUMMARY.md where we may add docs like this one.
Comment on lines
+3
to
+4
| - [Technical Specifications Document](https://github.com/stacks-network/stacks/blob/master/sBTC/sbtc_technical.md) | ||
| - [Product Requirements Document](https://github.com/stacks-network/stacks/blob/master/sBTC/sbtc_product.md) |
Contributor
There was a problem hiding this comment.
I'm not a fan of linking to this repository here. The TSD can be omitted, since all information is already present in these docs. The product requirements doc could be incorporated, and I see you've already created a placeholder file fore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added signer requirements and user stories to documentation