Repository navigation
Reject colliding PythonInterpreter file mounts - #10205
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
This reverts commit 8729b56. Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
isaacbmiller
marked this pull request as ready for review
August 14, 2026 10:49
Contributor
Greptile SummaryThe interpreter now rejects mount configurations that would expose different host files under the same sandbox filename, while preserving repeated references to the same canonical file. Confidence Score: 5/5No blocking failure remains. The exercised alias and basename collision path is rejected during interpreter construction before sandbox mounting begins.
What T-Rex did
Reviews (2): Last reviewed commit: "Handle aliased mount collisions" | Re-trigger Greptile |
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sandbox/<basename>Why
PythonInterpreterflattens configured file paths to basenames. Two files such asfirst/config.jsonandsecond/config.jsontherefore become one guest file, and sync can write that guest value back to both host paths.Rejecting the ambiguous configuration preserves the existing guest path convention without adding a new mapping API in a patch release.
Size
The implementation is 8 added production lines. The remaining diff is focused regression coverage.
Verification
git diff --checkpassed