Repository navigation
Isolate the PythonInterpreter Deno cache - #10206
Merged
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
This reverts commit 6a5d268. Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
This reverts commit 37722fa. Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
Amp-Thread-ID: https://ampcode.com/threads/T-019fcce1-bc8b-753e-886f-9b77c0ccb376 Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
isaacbmiller
marked this pull request as ready for review
August 14, 2026 10:49
Contributor
Greptile SummaryPythonInterpreter now starts from the existing warmed Deno cache in offline environments and revokes generated code’s access to unrelated cache files after Pyodide initialization. The exercised offline startup path returned the expected result, and focused cache-access coverage passed. Confidence Score: 5/5Safe to merge: offline startup succeeds from a warmed shared cache while unrelated cache contents remain inaccessible to generated code. No blocking failure remains.
What T-Rex did
Reviews (2): Last reviewed commit: "Revoke Deno cache access after startup" | Re-trigger Greptile |
Co-authored-by: Isaac Miller <isaac@cmpnd.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deno_commandbehavior unchangedScope
The production diff is 17 changed lines across
python_interpreter.pyandrunner.js(14 additions, 3 deletions).Verification
uv run pytest tests/primitives/test_python_interpreter.py -q --deno— 102 passed--cached-onlyruff check --fix-only --diff --exit-non-zero-on-fix ...— cleangit diff --check— clean