Skip to content

fix(ci): Enable pre-commit CI workflow on pull requests - #7824

Open
ulgens wants to merge 2 commits into
stanfordnlp:mainfrom
ulgens:run_precommit_on_PRs
Open

ulgens wants to merge 2 commits into
stanfordnlp:mainfrom
ulgens:run_precommit_on_PRs

Conversation

@ulgens

@ulgens ulgens commented Feb 20, 2025 •

Copy link
Copy Markdown
Contributor

Enables precommit_checks CI workflow on pull requests, so PRs with issues will be automatically detected during review process.

Relates to

@ulgens ulgens changed the title Enable pre-commit CI workflow on pull requests fix: Enable pre-commit CI workflow on pull requests Feb 20, 2025
@ulgens

ulgens commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

I updated the detail but I'm not allowed to rerun the pipeline. Even though that step succeeds, I expect another failure from the actual pre-commit step.

@okhat

okhat commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

Thanks so much @ulgens ! Should I merge this now? Or do you want to follow up with a different PR first?

@ulgens

ulgens commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

@okhat I'd like to apply fixes with several different PRs if that's okay. I don't really want to push a PR with 338 changed files.

@okhat

okhat commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

Yes that sounds good to me. But what's your plan? Should we merge this now or wait for other followups?

@ulgens

ulgens commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

Let's merge this one.

@okhat

okhat commented Feb 20, 2025

Copy link
Copy Markdown
Collaborator

And then?

@ulgens
ulgens force-pushed the run_precommit_on_PRs branch from 66fdae7 to ab9d916 Compare February 20, 2025 18:49
@ulgens
ulgens marked this pull request as draft February 20, 2025 18:49
@ulgens
ulgens force-pushed the run_precommit_on_PRs branch from ab9d916 to 4961ab0 Compare February 20, 2025 18:50
@ulgens

ulgens commented Feb 20, 2025 •

Copy link
Copy Markdown
Contributor Author

Then, I'm planning to create PRs like these

for each hook repos under pre-commit, and finally enable everything, optimize the pre-commit workflow and make it faster.

@ulgens ulgens mentioned this pull request Feb 20, 2025
@ulgens
ulgens force-pushed the run_precommit_on_PRs branch from 10230d6 to 35266a5 Compare May 3, 2025 07:54
@ulgens
ulgens marked this pull request as ready for review May 3, 2025 07:56
@ulgens

ulgens commented May 3, 2025

Copy link
Copy Markdown
Contributor Author

@okhat @chenmoneygithub Any luck on revisiting this PR? I saw that some CI work is in progress, this one could be helpful.

@ulgens
ulgens force-pushed the run_precommit_on_PRs branch from 35266a5 to c095d8a Compare April 1, 2026 22:39
@ulgens
ulgens force-pushed the run_precommit_on_PRs branch 2 times, most recently from d25a0cb to e67496f Compare April 1, 2026 22:42
@ulgens ulgens changed the title fix: Enable pre-commit CI workflow on pull requests fix(ci): Enable pre-commit CI workflow on pull requests Apr 1, 2026
@ulgens
ulgens force-pushed the run_precommit_on_PRs branch from e67496f to 6b9b0dd Compare April 1, 2026 22:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants