Repository navigation
feat(ci): Create PRs with ruff fixes automatically - #9336
Merged
Merged
Conversation
isaacbmiller
changed the title
isaacbmiller
marked this pull request as ready for review
February 26, 2026 14:48
isaacbmiller
added a commit
that referenced
this pull request
Feb 27, 2026
This reverts commit a8da470.
isaacbmiller
added a commit
that referenced
this pull request
Feb 27, 2026
MaximeRivest
pushed a commit
to MaximeRivest/dspy
that referenced
this pull request
Mar 5, 2026
* add auto-ruff fix * ruff fixable change * change pr targeting * remove merge condition * add a second ruff error * fix: ruff auto-fix for stanfordnlp#9336 (stanfordnlp#9338) Co-authored-by: isaacbmiller <17116851+isaacbmiller@users.noreply.github.com> * Delete dspy/ruff_autofix_smoke.py * add a concurrency group for prs --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
MaximeRivest
pushed a commit
to MaximeRivest/dspy
that referenced
this pull request
Mar 5, 2026
…lp#9336)" (stanfordnlp#9345) This reverts commit a8da470.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when Ruff found auto-fixable lint issues in a PR, the CI simply failed and told the developer to run pre-commit run --all-files locally.
Now, the CI automatically creates a rolling fix PR targeting the source PR's branch (e.g., ci/ruff-autofix/pr-123 → source branch). If the source PR gets new commits that still have issues, the fix PR is updated in place. The CI step still fails so the check doesn't silently pass.
A companion workflow close_ruff_autofix_pr.yml:1-5 auto-closes the fix PR when the source PR is closed or merged.
Auto-fix PR creation is skipped for forks and non-PR events since the workflow can't push to external repos.