Reject bids with invalid prev_randao during gossip validation - #8609
Merged
Conversation
When someone sends us a bid with invalid prev_randao but high value, it kicks out the legitimate bid. The invalid one is also non-punishable as it fails subsequent state transition by peers. Add an extra reject rule to filter out invalid prev_randao, there is only a single valid value for each parent block root, and we have efficient functionality in the blockchain_dag to obtain correct RANDAO without expensive state replays. Also proposed for spec inclusion, but we'll need the rule regardless: - ethereum/consensus-specs#5360 Have moved this check to the end, because if the correct value has not yet been cached (i.e., no valid bid received), we may have to load the block from disk (once).
tersec
reviewed
Jun 16, 2026
Contributor
|
Merge conflict in beacon_chain/consensus_object_pools/execution_payload_pool.nim |
etan-status
commented
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When someone sends us a bid with invalid prev_randao but high value, it kicks out the legitimate bid. The invalid one is also non-punishable as it fails subsequent state transition by peers.
Add an extra reject rule to filter out invalid prev_randao, there is only a single valid value for each parent block root, and we have efficient functionality in the blockchain_dag to obtain correct RANDAO without expensive state replays.
Also proposed for spec inclusion, but we'll need the rule regardless:
prev_randaoduring gossip validation ethereum/consensus-specs#5360Have moved this check to the end, because if the correct value has not yet been cached (i.e., no valid bid received), we may have to load the block from disk (once).