Keep numeric IDs, cast them, and drop duplicates in delete_many

Author: sdokus

src/Schema/Traits/Custom_Table_Query_Methods.php

@@ -177,7 +177,7 @@ public static function delete( int $uid, string $column = '' ): bool {
 	 * Deletes multiple rows from the table.
 	 *
 	 * @since 3.0.0
-	 * @since TBD IDs are passed to the query as placeholders, and non-positive IDs are ignored for integer columns.
+	 * @since TBD IDs are passed to the query as placeholders, non-numeric IDs are ignored for integer columns, and duplicates are removed.
 	 *
 	 * @param array<int|string> $ids        The IDs of the rows to delete.
 	 * @param string            $column     The column to use for the delete query.
@@ -194,9 +194,11 @@ public static function delete_many( array $ids, string $column = '', string $mor
 			$column_object = $columns->get( $column_name );
 			$is_int        = $column_object && PHP_Types::INT === $column_object->get_php_type();
 
-			$column_ids = $is_int ?
-				array_filter( array_map( fn( $id ) => filter_var( is_string( $id ) && ctype_digit( $id ) ? ltrim( $id, '0' ) : $id, FILTER_VALIDATE_INT, [ 'options' => [ 'min_range' => 1 ] ] ), $ids ) ) :
-				array_filter( array_map( 'strval', $ids ), fn( $id ) => '' !== $id );
+			$column_ids = array_unique(
+				$is_int ?
+					array_map( 'intval', array_filter( $ids, 'is_numeric' ) ) :
+					array_filter( array_map( 'strval', $ids ), fn( $id ) => '' !== $id )
+			);
 
 			if ( empty( $column_ids ) ) {
 				return false;

tests/wpunit/Traits/Custom_Table_Query_MethodsTest.php

@@ -1038,7 +1038,7 @@ public function should_delete_many_by_int_and_numeric_string_ids() {
 
 		$ids = $this->insert_delete_fixtures( $table, 4 );
 
-		$this->assertSame( 2, $table::delete_many( [ $ids[0], (string) $ids[1] ] ) );
+		$this->assertSame( 2, $table::delete_many( [ $ids[0], (string) $ids[1], $ids[0] ] ) );
 		$this->assertSame( 1, $table::delete_many( [ '000' . $ids[3] ] ) );
 		$this->assertNull( $table::get_by_id( $ids[3] ) );
 		$this->assertNull( $table::get_by_id( $ids[0] ) );
@@ -1057,7 +1057,7 @@ public function should_not_delete_anything_for_non_positive_ids() {
 
 		$ids = $this->insert_delete_fixtures( $table, 2 );
 
-		$this->assertFalse( $table::delete_many( [ -$ids[0], 0, '-' . $ids[1], '0' ] ) );
+		$this->assertSame( 0, $table::delete_many( [ -$ids[0], 0, '-' . $ids[1], '0' ] ) );
 		$this->assertFalse( $table::delete( -$ids[0] ) );
 		$this->assertFalse( $table::delete( 0 ) );
 		$this->assertEquals( 2, $table::get_total_items() );