refactor: improve log output in cleanup functions - #663
Open
rohan-stepsecurity wants to merge 19 commits into
Open
refactor: improve log output in cleanup functions#663rohan-stepsecurity wants to merge 19 commits into
rohan-stepsecurity wants to merge 19 commits into
Conversation
- **Grouped Logs:** Agent, daemon, and service logs are now enclosed within `core.startGroup()` and `core.endGroup()` calls. This provides better organization and readability in the GitHub Actions logs. - **Error Output:** In the `handleLinuxCleanup` function, any `stdout` from an error during `journalctl` execution is now also logged, providing more context for debugging.
…ctions - Replace @actions/http-client socketTimeout with fetch + AbortSignal.timeout(3s) on monitor, tls-inspect, policy fetch, policy-store fetch, and addSummary, so DNS + TCP connect + TLS are bounded (was unbounded, causing ~2-4 min hangs) - Add unhandledRejection guard in setup.ts and cleanup.ts so Node 22+ does not silently kill the step on background async errors from third-party deps - Skip Windows post-step cleanup when agent dir is missing (Pre-step crashed before install), instead of throwing ENOENT on post_event.json - Bump @types/node to ^24, typescript to ^5, ts-jest to ^29.4 to match node24 runtime and enable AbortSignal.timeout typings
handleLinuxCleanup and handleMacosCleanup also did an unconditional writeFileSync to a path inside the agent dir, throwing ENOENT when Pre-step crashed before installing the agent (proven by integration test on synthetic-reject branch). Mirror the same dir-existence check that handleWindowsCleanup already has.
- **Grouped Logs:** Agent, daemon, and service logs are now enclosed within `core.startGroup()` and `core.endGroup()` calls. This provides better organization and readability in the GitHub Actions logs. - **Error Output:** In the `handleLinuxCleanup` function, any `stdout` from an error during `journalctl` execution is now also logged, providing more context for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core.startGroup()andcore.endGroup()calls. This provides better organization and readability in the GitHub Actions logs.handleLinuxCleanupfunction, anystdoutfrom an error duringjournalctlexecution is now also logged, providing more context for debugging.