chore: clean up UNUSED usage

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>

Author: fpistm

cores/arduino/Tone.cpp

@@ -141,19 +141,19 @@ void noTone(uint8_t _pin, bool destruct)
 #warning "TIMER_TONE or HAL_TIM_MODULE_ENABLED not defined"
 void tone(uint8_t _pin, unsigned int frequency, unsigned long duration)
 {
-  UNUSED(_pin);
-  UNUSED(frequency);
-  UNUSED(duration);
+  (void)_pin;
+  (void)frequency;
+  (void)duration;
 }
 
 void noTone(uint8_t _pin)
 {
-  UNUSED(_pin);
+  (void)_pin;
 }
 
 void noTone(uint8_t _pin, bool destruct)
 {
-  UNUSED(_pin);
-  UNUSED(destruct);
+  (void)_pin;
+  (void)destruct;
 }
 #endif /* HAL_TIM_MODULE_ENABLED && TIMER_TONE && !HAL_TIM_MODULE_ONLY*/

cores/arduino/WInterrupts.cpp

@@ -64,9 +64,9 @@ void attachInterrupt(pin_size_t interruptNumber, voidFuncPtr callback, PinStatus
   callback_function_t _c = callback;
   attachInterrupt(interruptNumber, _c, mode);
 #else
-  UNUSED(interruptNumber);
-  UNUSED(callback);
-  UNUSED(mode);
+  (void)interruptNumber;
+  (void)callback;
+  (void)mode;
 #endif
 }
 
@@ -80,6 +80,6 @@ void detachInterrupt(pin_size_t interruptNumber)
   }
   stm32_interrupt_disable(port, STM_GPIO_PIN(p));
 #else
-  UNUSED(interruptNumber);
+  (void)interruptNumber;
 #endif
 }

cores/arduino/wiring_analog.c

@@ -179,7 +179,7 @@ static inline uint32_t mapResolution(uint32_t value, uint32_t from, uint32_t to)
 
 void analogReference(uint8_t mode)
 {
-  UNUSED(mode);
+  (void)mode;
 }
 
 // Perform the read operation on the selected analog pin.
@@ -194,7 +194,7 @@ int analogRead(pin_size_t pinNumber)
     value = mapResolution(value, _internalReadResolution, _readResolution);
   }
 #else
-  UNUSED(pinNumber);
+  (void)pinNumber;
 #endif
   return value;
 }

libraries/IWatchdog/src/IWatchdog.cpp

@@ -116,7 +116,7 @@ void IWatchdogClass::set(uint32_t timeout, uint32_t window)
     LL_IWDG_SetWindow(IWDG, reload);
   }
 #else
-  UNUSED(window);
+  (void)window;
 #endif
 
   // Wait for the registers to be updated (IWDG_SR = 0x0000 0000)
@@ -155,7 +155,7 @@ void IWatchdogClass::get(uint32_t *timeout, uint32_t *window)
       *window = (uint32_t)((4 << prescaler) * (win + 1) * base);
     }
 #else
-    UNUSED(window);
+    (void)window;
 #endif
   }
 }

libraries/Servo/src/stm32/Servo.cpp

@@ -200,24 +200,24 @@ bool Servo::attached()
 Servo::Servo() {}
 uint8_t Servo::attach(pin_size_t pin)
 {
-  UNUSED(pin);
+  (void)pin;
   return 0;
 }
 uint8_t Servo::attach(pin_size_t pin, int min, int max)
 {
-  UNUSED(pin);
-  UNUSED(min);
-  UNUSED(max);
+  (void)pin;
+  (void)min;
+  (void)max;
   return 0;
 }
 void Servo::detach() {}
 void Servo::write(int value)
 {
-  UNUSED(value);
+  (void)value;
 }
 void Servo::writeMicroseconds(int value)
 {
-  UNUSED(value);
+  (void)value;
 }
 int Servo::read()
 {

libraries/SrcWrapper/inc/PinAF_STM32F1.h

@@ -192,7 +192,7 @@ static inline void pinF1_DisconnectDebug(PinName pin)
     __HAL_AFIO_REMAP_SWJ_NOJTAG(); // JTAG-DP Disabled and SW-DP enabled
   }
 #else
-  UNUSED(pin);
+  (void)pin;
 #endif /* STM32F1_FORCE_DEBUG */
 }
 

libraries/SrcWrapper/inc/backup.h

@@ -160,8 +160,8 @@ static inline void setBackupRegister(uint32_t index, uint32_t value)
 #elif defined(PWR_BKP0R)
   LL_PWR_BKP_SetRegister(index, value);
 #else
-  UNUSED(index);
-  UNUSED(value);
+  (void)index;
+  (void)value;
 #endif
 }
 
@@ -184,7 +184,7 @@ static inline uint32_t getBackupRegister(uint32_t index)
 #elif defined(PWR_BKP0R)
   return LL_PWR_BKP_GetRegister(index);
 #else
-  UNUSED(index);
+  (void)index;
   return 0;
 #endif
 }
@@ -198,9 +198,9 @@ static inline void writeBackupSRAM(uint32_t offset, uint32_t *data, uint32_t len
     *(__IO uint32_t *)(BKPSRAM_BASE + (offset + i) * 4) = data[i];
   }
 #else
-  UNUSED(offset);
-  UNUSED(data);
-  UNUSED(length);
+  (void)offset;
+  (void)data;
+  (void)length;
 #endif
 }
 
@@ -213,9 +213,9 @@ static inline void readBackupSRAM(uint32_t offset, uint32_t *data, uint32_t leng
     data[i] = *(__IO uint32_t *)(BKPSRAM_BASE + (offset + i) * 4);
   }
 #else
-  UNUSED(offset);
-  UNUSED(data);
-  UNUSED(length);
+  (void)offset;
+  (void)data;
+  (void)length;
 #endif
 }
 

libraries/SrcWrapper/inc/lock_resource.h

@@ -201,8 +201,8 @@ static inline void hsem_lock(uint32_t semID, uint32_t retry)
     }
   }
 #else
-  UNUSED(semID);
-  UNUSED(retry);
+  (void)semID;
+  (void)retry;
 #endif /* STM32MP1xx || STM32WBxx */
 }
 
@@ -218,7 +218,7 @@ static inline void hsem_unlock(uint32_t semID)
     LL_HSEM_ReleaseLock(HSEM, semID, 0);
   }
 #else
-  UNUSED(semID);
+  (void)semID;
 #endif /* STM32MP1xx || STM32WBxx */
 }
 

libraries/SrcWrapper/inc/pinconfig.h

@@ -24,7 +24,7 @@ static inline void pin_DisconnectDebug(PinName pin)
 #ifdef STM32F1xx
   pinF1_DisconnectDebug(pin);
 #else
-  UNUSED(pin);
+  (void)pin;
 #endif /* STM32F1xx */
 }
 
@@ -54,8 +54,8 @@ static inline void pin_PullConfig(GPIO_TypeDef *gpio, uint32_t ll_pin, uint32_t
 static inline void pin_SetAFPin(GPIO_TypeDef *gpio, PinName pin, uint32_t afnum)
 {
 #ifdef STM32F1xx
-  UNUSED(gpio);
-  UNUSED(pin);
+  (void)gpio;
+  (void)pin;
   pin_SetF1AFPin(afnum);
 #else
   uint32_t ll_pin  = STM_LL_GPIO_PIN(pin);

libraries/SrcWrapper/inc/stm32_def.h

@@ -76,6 +76,12 @@
 
 #if defined(USE_HALV2_DRIVER)
   #include "stm32_hal.h"
+
+  /* Define to avoid any backward compatibility issues */
+  /* but prefer avoid using it, use (void)variable instead */
+  #ifndef UNUSED
+    #define UNUSED STM32_UNUSED
+  #endif /* UNUSED */
 #endif /* USE_HALV2_DRIVER */
 
 #ifndef F_CPU