Repository navigation
Conversation
fpistm
commented
Nov 6, 2026
fpistm
commented
Member
- Clarify the license coverage of core, library, variant, and middleware files in License.md.
- Document license boundaries, Apache 2.0/LGPLv2.1 compatibility considerations, and SLA0044 restrictions.
- Add third-party copyright and license attributions, including for downloaded CMSIS packages.
- Add BSD 3-Clause headers to the I3C source files.
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Fix the pinmap.h and STM32_USB_*_Library paths, which did not exist. List the directories that were missing or wrongly attributed: - cores/arduino/api, cores/arduino/stm32 (LGPL-2.1) - libraries using LGPL-2.1 or BSD 3-Clause (EEPROM, Wire, USBDevice, SubGhz, RGB_LED_TLC59731, SrcWrapper, ...) - the BSD 3-Clause headers in cores/arduino and variants - the MIT files (HardwareTimer, new.cpp, Udp.h, VirtIOSerial, ...) Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Assisted-by: GitHub Copilot
The Ultimate Liberty License (SLA0044) is not an open source license: it restricts use to STMicroelectronics devices and forbids placing the software under Open Source Terms. Summarize these terms next to the license reference so redistributors are aware of them. Add a note stating that each file keeps its own license, and that Apache-2.0 files must not be merged into LGPL-2.1 files as the two are not compatible. Document the GPLv2 licensed OpenAMP spelling.txt data file, which is only used by development scripts and is not part of the core build. Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Assisted-by: GitHub Copilot
List the files written by third parties (Teensyduino, Daniel Fekete, Bumsik Kim, Bjoern Hartmann, Arduino, Mentor Graphics, Xilinx) with their copyright holder and license, so the notices to retain are easy to find. Mention the Arm CMSIS, CMSIS-DSP and CMSIS-NN packages, which are Apache-2.0 licensed and downloaded as tools instead of being shipped in this repository. Signed-off-by: Frederic Pillon <frederic.pillon@st.com> Assisted-by: GitHub Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.