Fix operation directive argument coercion (#4596)

Author: patrick91

RELEASE.md

@@ -0,0 +1,22 @@
+---
+release type: patch
+social_messages:
+  x: >-
+    {project_name} {version} is out! Operation directive resolvers now receive
+    correctly typed arguments, including inputs, enums, custom scalars, and
+    defaults. 🍓 https://strawberry.rocks/release/{version}
+  linkedin: >-
+    {project_name} {version} is out. Operation directive arguments now behave
+    like field arguments, with standard GraphQL coercion and Strawberry input
+    conversion for literals, variables, defaults, and explicit null values. 🍓
+---
+
+This release fixes argument handling for operation directive resolvers.
+
+Arguments passed to operation directives now use GraphQL's standard coercion before
+your resolver runs. Directive resolvers receive Python numeric values, Strawberry
+enum members and nested input objects, and values parsed by custom scalars, whether
+clients use literals or variables.
+
+When a client omits a variable, Strawberry now applies the directive argument's
+default. Explicit `null` continues to reach nullable arguments as `None`.

docs/types/operation-directives.md

@@ -98,11 +98,11 @@ query People($identified: Boolean!) {
   person {
     name @turnUppercase
   }
-  jess: person {
-    name @replace(old: "Jess", new: "Jessica")
+  duck: person {
+    name @replace(old: "Duck", new: "Duck")
   }
   johnDoe: person {
-    name @replace(old: "Jess", new: "John") @include(if: $identified)
+    name @replace(old: "Duck", new: "John") @include(if: $identified)
   }
 }
 ```

strawberry/extensions/directives.py

@@ -2,8 +2,11 @@
 
 from typing import TYPE_CHECKING, Any
 
+from graphql import get_argument_values
+
 from strawberry.extensions import SchemaExtension
-from strawberry.types.nodes import convert_arguments
+from strawberry.types.arguments import convert_arguments
+from strawberry.utils import IS_GQL_33
 from strawberry.utils.await_maybe import await_maybe
 
 if TYPE_CHECKING:
@@ -76,7 +79,25 @@ def process_directive(
     strawberry_directive = schema.get_directive_by_name(directive_name)
     assert strawberry_directive is not None, f"Directive {directive_name} not found"
 
-    arguments = convert_arguments(info=info, nodes=directive.arguments)
+    directive_definition = info.schema.get_directive(directive_name)
+    assert directive_definition is not None, f"Directive {directive_name} not found"
+
+    variable_values: Any = info.variable_values
+    if IS_GQL_33 and not hasattr(variable_values, "coerced"):
+        # Strawberry exposes a plain dict, while graphql-core 3.3 expects its
+        # VariableValues container when coercing arguments.
+        from graphql.execution import values as execution_values
+
+        variable_values_type = vars(execution_values)["VariableValues"]
+        variable_values = variable_values_type({}, variable_values)
+
+    arguments = get_argument_values(directive_definition, directive, variable_values)
+    arguments = convert_arguments(
+        arguments,
+        strawberry_directive.arguments,
+        scalar_registry=schema.schema_converter.scalar_registry,
+        config=schema.config,
+    )
     resolver = strawberry_directive.resolver
 
     info_parameter = resolver.info_parameter

tests/schema/extensions/schema_extensions/conftest.py

@@ -47,7 +47,7 @@ def assert_expected(cls) -> None:
 def default_query_types_and_query() -> SchemaHelper:
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:

tests/schema/extensions/schema_extensions/test_extensions.py

@@ -18,7 +18,7 @@
 def test_base_extension():
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -62,7 +62,7 @@ class ExtensionNoHooks(SchemaExtension): ...
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -100,7 +100,7 @@ def on_parse(self):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -135,7 +135,7 @@ def on_operation(self):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -288,7 +288,7 @@ async def on_parse(self):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:

tests/schema/extensions/test_apollo.py

@@ -21,7 +21,7 @@ def test_tracing_sync(mocker):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -76,7 +76,7 @@ async def test_tracing_async(mocker):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -143,7 +143,7 @@ def test_should_not_trace_introspection_sync_queries(mocker):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:
@@ -178,7 +178,7 @@ async def test_should_not_trace_introspection_async_queries(mocker):
 
     @strawberry.type
     class Person:
-        name: str = "Jess"
+        name: str = "Duck"
 
     @strawberry.type
     class Query:

tests/schema/extensions/test_opentelemetry.py

@@ -19,7 +19,7 @@ def global_tracer_mock(mocker: MockerFixture) -> MagicMock:
 
 @strawberry.type
 class Person:
-    name: str = "Jess"
+    name: str = "Duck"
 
 
 @strawberry.type