-
-
Notifications
You must be signed in to change notification settings - Fork 660
feat: add field_args property to Info #4484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rcybulski1122012
wants to merge
8
commits into
strawberry-graphql:main
Choose a base branch
from
rcybulski1122012:info-field-args
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
10a43f5
feat: add field_args property to Info
rcybulski1122012 17617b9
docs: add RELEASE.md
rcybulski1122012 6916838
docs: mention the property
rcybulski1122012 1112e2a
fix: avoid graphql-core 3.3 incompatible get_field_def import
rcybulski1122012 681f968
refactor: address review feedback on Info.field_args
rcybulski1122012 f3ada97
fix: wrap variable values for get_argument_values on graphql-core 3.3
rcybulski1122012 6e956c6
fix: silence mypy attr-defined for 3.3-only VariableValues import
rcybulski1122012 f7495d8
fix: also silence pyright for 3.3-only VariableValues import
rcybulski1122012 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| --- | ||
| release type: minor | ||
| --- | ||
|
|
||
| This release adds `Info.field_args`, a cached property that returns the arguments | ||
| passed to the current field, already converted to Strawberry types. Scalars are | ||
| coerced and input types are converted to their proper dataclasses, mirroring the | ||
| values a resolver receives. Both inline literals and variables are handled, and | ||
| arguments that were not provided are omitted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.