fix: preserve model materials across source reimport - #3366
Open
Kreblc3428 wants to merge 1 commit into
Open
Conversation
Member
|
This kind of changes needs new tests to cover that specific scenario. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Details
Fixes model material assignments becoming misaligned or losing references when updating a model from source after materials are removed and later restored.
The importer now aligns saved materials to the current source material order by name, while the editor reconnects genuinely reintroduced material slots to an existing same-named material asset.
Tested with the reproduction from #3363, including repeated v1 ? v2 ? v1 updates, multiple material removals, manual overrides, save/reopen, and running the editor.
Developed with assistance from ChatGPT using GPT-5.6 Sol. The final changes were reviewed and tested before submission.
Related Issue
Fixes #3363
Types of changes
Checklist