Conversation
Progress events were sent on a blocking channel from inside the PTP data phase, i.e. with the client transaction mutex held. Once the 32-slot event channel filled -- roughly five files in, at ~8 events per 23 MB NEF -- the importer blocked there while still holding mu, and the renderer blocked in View() -> Connected() waiting for that same mu. Neither side could proceed, so the whole TUI froze, keyboard included. Two changes, either of which breaks the cycle: - Progress sends are now non-blocking (trySend). Progress is a lossy signal by nature: the next tick carries the same cumulative totals. The lifecycle events the UI must not miss (FileStarted/FileDone/FileSkipped/AllDone/ Error) are still sent normally, and none of those are emitted under mu. - Connected() reads an atomic mirror of cmdConn instead of taking mu, so the render path can never block behind an in-flight transfer. Verified on a Nikon D5300 over Wi-Fi: 20 files / 320 MB imported back to back with no stall, longest gap between files 11s. Before, imports never got past 6 files without freezing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress events were sent on a blocking channel from inside the PTP data phase, i.e. with the client transaction mutex held. Once the 32-slot event channel filled -- roughly five files in, at ~8 events per 23 MB NEF -- the importer blocked there while still holding mu, and the renderer blocked in View() -> Connected() waiting for that same mu. Neither side could proceed, so the whole TUI froze, keyboard included.
Two changes, either of which breaks the cycle:
Progress sends are now non-blocking (trySend). Progress is a lossy signal by nature: the next tick carries the same cumulative totals. The lifecycle events the UI must not miss (FileStarted/FileDone/FileSkipped/AllDone/ Error) are still sent normally, and none of those are emitted under mu.
Connected() reads an atomic mirror of cmdConn instead of taking mu, so the render path can never block behind an in-flight transfer.
Verified on a Nikon D5300 over Wi-Fi: 20 files / 320 MB imported back to back with no stall, longest gap between files 11s. Before, imports never got past 6 files without freezing.
Fixes #1