Add Cressi Raffaello (model 6) to the Goa family - #134
Open
mikeller wants to merge 1 commit into
Open
Conversation
The Raffaello identifies itself as model 6 via the CMD_VERSION response. It is fully compatible with the existing Goa BLE protocol and parser; firmware 3.09 maps to format version 5 via the existing firmware-range logic. Add a descriptor entry and include model 6 in the BLE filter so the Raffaello can be selected directly by name and auto-detected via its '6_<hex>' BLE advertisement prefix. Tested against a Cressi Raffaello (firmware 3.09, hardware 2.09) with the Cressi KS881000 Bluetooth interface on macOS; all 24 dives downloaded successfully. // AI-generated (Claude) Signed-off-by: Michael Keller <github@ike.ch>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The functional changes are minimal and consistent with existing Goa-family handling, with only a minor table formatting nit noted.
Pull request overview
Adds support for the Cressi Raffaello as part of the existing Cressi Goa device family so it can be selected by name and auto-detected over BLE using the existing Cressi BLE matching logic.
Changes:
- Add a new
dc_descriptor_tentry for Cressi Raffaello (model 6) underDC_FAMILY_CRESSI_GOA. - Include model 6 in the Cressi BLE model filter list so BLE auto-detection recognizes the
6_<hex>advertisement prefix.
File summaries
| File | Description |
|---|---|
| src/descriptor.c | Adds the Raffaello descriptor (model 6) and includes model 6 in the Cressi BLE filter list for Goa-family auto-detection. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| {"Cressi", "Leonardo 2.0", DC_FAMILY_CRESSI_GOA, 3, DC_TRANSPORT_SERIAL | DC_TRANSPORT_BLE, dc_filter_cressi}, | ||
| {"Cressi", "Donatello", DC_FAMILY_CRESSI_GOA, 4, DC_TRANSPORT_SERIAL | DC_TRANSPORT_BLE, dc_filter_cressi}, | ||
| {"Cressi", "Michelangelo", DC_FAMILY_CRESSI_GOA, 5, DC_TRANSPORT_SERIAL | DC_TRANSPORT_BLE, dc_filter_cressi}, | ||
| {"Cressi", "Raffaello", DC_FAMILY_CRESSI_GOA, 6, DC_TRANSPORT_SERIAL | DC_TRANSPORT_BLE, dc_filter_cressi}, |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Raffaello identifies itself as model 6 via the CMD_VERSION response.
It is fully compatible with the existing Goa BLE protocol and parser;
firmware 3.09 maps to format version 5 via the existing firmware-range
logic.
Add a descriptor entry and include model 6 in the BLE filter so the
Raffaello can be selected directly by name and auto-detected via its
'6_' BLE advertisement prefix.