Skip to content

馃悰(frontend) fix drag-and-drop move disabled by viewport breakpoint on tree - #2788

Merged
AntoLC merged 1 commit into
mainfrom
fix/2599-dnd-move-breakpoint
Oct 16, 2026
Merged

AntoLC merged 1 commit into
mainfrom
fix/2599-dnd-move-breakpoint

Conversation

@AntoLC

@AntoLC AntoLC commented Oct 6, 2026

Copy link
Copy Markdown
Member

Purpose

Drag-and-drop to move a document was disabled below a viewport width breakpoint. Browser zoom shrinks window.innerWidth like a narrower window does, so zooming in on a desktop with a mouse silently disabled moving documents, in the docs grid and in the doc tree.

Fixes #2599

Proposal

  • add a hasCoarsePointer flag to useResponsiveStore, backed by the (pointer: coarse) media query
  • use it instead of isLargeScreen / isDesktop to gate move drag-and-drop in the docs grid (DocGridContentList) and the doc tree (DocTreeSubpages)
  • touch-primary devices still get the non-draggable fallback

@AntoLC AntoLC added bug Something isn't working frontend responsive labels Oct 6, 2026
@AntoLC AntoLC self-assigned this Oct 6, 2026
@github-actions

github-actions Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Size Change: -144 B (0%)

Total Size: 4.08 MB

馃摝 View Changed
Filename Size Change
apps/impress/out/_next/static/103ea392/_buildManifest.js 740 B +740 B (new file) 馃啎
apps/impress/out/_next/static/112e3885/_buildManifest.js 0 B -741 B (removed) 馃弳
apps/impress/out/_next/static/chunks/6420.js 86.1 kB +86.1 kB (new file) 馃啎
apps/impress/out/_next/static/chunks/9042.js 0 B -86.3 kB (removed) 馃弳

compressed-size-action

@AntoLC
AntoLC force-pushed the fix/2599-dnd-move-breakpoint branch from 69afe38 to 65ac931 Compare October 6, 2026 09:52
@AntoLC
AntoLC requested a review from Ovgodd October 6, 2026 12:46
@AntoLC AntoLC changed the title 馃悰(frontend) fix drag-and-drop move disabled by viewport breakpoint 馃悰(frontend) fix drag-and-drop move disabled by viewport breakpoint on tree Oct 6, 2026

@Ovgodd Ovgodd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Drag-and-drop to move a document was disabled below a viewport
width breakpoint.
Browser zoom shrinks window.innerWidth like a narrower window
does, so zooming in on a desktop with a mouse silently disabled
moving documents, in the docs grid and in the doc tree.

A fix was made on the doc grid, but not in the tree,
we updated useResponsiveStore to tell us if the window
has coarse pointer or not (hasCoarsePointer).

Closes #2599
@AntoLC
AntoLC force-pushed the fix/2599-dnd-move-breakpoint branch from 65ac931 to 5bb089e Compare October 16, 2026 13:53
@AntoLC
AntoLC merged commit 5bb089e into main Oct 16, 2026
50 of 51 checks passed
@AntoLC
AntoLC deleted the fix/2599-dnd-move-breakpoint branch October 16, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend responsive

Projects

None yet

Development

Successfully merging this pull request may close these issues.

馃悰(Bug) can't move a doc into another bcse of breakpoint

2 participants