Repository navigation
Conversation
There was a problem hiding this comment.
🤖 AI Review
Both independent reviews were available. Claude's sole finding is refuted: schema validation, required defaults, and API normalization prevent the claimed invalid OAuth companion values from reaching this branch. No additional defects were found. Verification was by code inspection; tests were not run.
Findings
No issues found.
Refuted findings (kept for transparency, not posted as review comments)
apps/cli/src/commands/config/push/push.encoders.ts:1407(error-handling): The OAuth companion fallback skips validation and can send undefined or wrongly typed values, or resend a companion already reported as unencodable.
Refuted: The claimed inputs cannot arise through config push. packages/config/src/auth/index.ts:180-199 requires a boolean enabled value and string authorization_url_path, with decoding defaults for both fields and their container. Config loading validates the document (packages/config/src/io.ts:455-473), and push.handler.ts:243,615-623 passes that decoded config as the final fallback, so missing projected values still resolve to defined, correctly typed values. Remote OAuth values are narrowed by boolRow/stringRow (registry-auth.ts:392-412,769-775) before encoding; null values are omitted. Routed changes come from the validated local projection (config-diff.ts:358-452), and push.plan.ts:138-147 excludes remote_only changes. Thus neither an invalid routed OAuth change nor an undefined final companion reaches this branch.
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 0 · Refuted: 1 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Coly010
left a comment
There was a problem hiding this comment.
LGTM, thanks! one optional nit: resolveStorageFeatureLeaf is shared with the oauth pair now, so a neutral name (resolvePrunedLeaf?) might read better than listing its callers in the doc comment. totally fine to leave as is
TL;DR
fixes
config pushfailing when the oauth server path changes or the server is turned on or offwhats improved/fixed?
the api only accepts
oauth_server_enabledandoauth_server_authorization_pathtogether, butconfig pushsent just the changed onehow?
send the missing one too, using the linked project's current value (so enabling keeps a stored custom path), else the config value or default
ref: