Repository navigation
fix(api): keep annotated binary request bodies typed as BinaryInput - #7443
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
CLI benchmark (Lightweight Commands): no changes foundCommit
API calls: unchanged for all 7 commands. Binary size: 134.0 MB, unchanged. Details: timing ranges, API calls per command, slowest phasesTiming ranges
API calls per command
Slowest phasesNo command moved beyond noise, so there are no phase deltas. Comment |
There was a problem hiding this comment.
🤖 AI Review
Confirmed both Claude findings: binary normalization drops nullability, and the annotation regression lacks a focused test. The nullability issue does not affect the current committed binary schemas. Codex reported no findings.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| 🟡 MINOR | packages/api/scripts/generate.ts:312 |
correctness |
claude | Binary normalization discards nullable: true, causing nullable binary values to generate as non-nullable schemas. |
| 🟡 MINOR | packages/api/scripts/generate.ts:310 |
test-coverage |
claude | No focused test covers a binary schema with a description, so removing this fix would not fail the existing binary generator test. |
Stats
Claude findings: 2 · Codex findings: 0 · Confirmed: 2 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Management API spec now describes the ESZIP update-function body through a shared component that carries a
descriptionandcontentEncoding. The generator only rewrote a bare{ format: "binary" }annotation toBinaryInput, so this body regenerated asSchema.Stringand rejectedUint8Array/ArrayBuffer/Blobuploads (breakingfunctions deploy).The sanitizer now reduces binary string schemas to their type and format, so they keep generating as
BinaryInput. Generated output ondevelopis unchanged; this unblocks the API sync in #7418, which still needs its v2 PostgREST config fixture updated for the newdb_pool_max_lifetime/db_pool_max_idletimefields.🤖 Generated with Claude Code