revert: drop the default extension install schema setting, landing separately with salt sync and a breaking change announcement

Author: utkarash2991

ansible/files/postgresql_config/supautils.conf.j2

@@ -8,7 +8,6 @@ supautils.drop_trigger_grants = '{"postgres":["auth.audit_log_entries","auth.flo
 # omitted because protected:                 plpgsql
 # NOTE: keep nix/tests/prime-superuser.sql in sync with the "may be unsafe" + "deprecated" lists above.
 supautils.privileged_extensions = 'address_standardizer, address_standardizer_data_us, amcheck, autoinc, bloom, btree_gin, btree_gist, citext, cube, dblink, dict_int, dict_xsyn, earthdistance, fuzzystrmatch, hstore, http, hypopg, index_advisor, insert_username, intarray, isn, ltree, moddatetime, orioledb, pg_buffercache, pg_cron, pg_graphql, pg_hashids, pg_jsonschema, pg_net, pg_prewarm, pg_repack, pg_stat_monitor, pg_stat_statements, pg_tle, pg_trgm, pg_walinspect, pgaudit, pgcrypto, pgjwt, pgroonga, pgroonga_database, pgrouting, pgrowlocks, pgsodium, pgstattuple, pgtap, plcoffee, pljava, plls, plpgsql_check, plv8, postgis, postgis_raster, postgis_sfcgal, postgis_tiger_geocoder, postgis_topology, postgres_fdw, refint, rum, seg, sslinfo, supabase_vault, supautils, tablefunc, tcn, timescaledb, tsm_system_rows, tsm_system_time, unaccent, uuid-ossp, vector, wrappers'
-supautils.default_extension_install_schema = 'extensions'
 supautils.extension_custom_scripts_path = '/etc/postgresql-custom/extension-custom-scripts'
 supautils.restrict_extension_versions = 'warn'
 supautils.privileged_extensions_superuser = 'supabase_admin'

nix/tests/expected/evtrigs.out

@@ -20,8 +20,8 @@ order by e.evtname;
  issue_pg_graphql_access                | supabase_admin | extensions         | grant_pg_graphql_access            | supabase_admin
  issue_pg_net_access                    | supabase_admin | extensions         | grant_pg_net_access                | supabase_admin
  pg_tle_event_trigger_for_drop_function | supabase_admin | pgtle              | pgtle.pg_tle_feature_info_sql_drop | supabase_admin
- pgaudit_ddl_command_end                | supabase_admin | extensions         | pgaudit_ddl_command_end            | supabase_admin
- pgaudit_sql_drop                       | supabase_admin | extensions         | pgaudit_sql_drop                   | supabase_admin
+ pgaudit_ddl_command_end                | supabase_admin | public             | pgaudit_ddl_command_end            | supabase_admin
+ pgaudit_sql_drop                       | supabase_admin | public             | pgaudit_sql_drop                   | supabase_admin
  pgrst_ddl_watch                        | supabase_admin | extensions         | pgrst_ddl_watch                    | supabase_admin
  pgrst_drop_watch                       | supabase_admin | extensions         | pgrst_drop_watch                   | supabase_admin
  pgsodium_trg_mask_update               | supabase_admin | pgsodium           | pgsodium.trg_mask_update           | supabase_admin

nix/tests/expected/pgrst_watch_triggers.out

@@ -12,7 +12,7 @@
 -- returns how many notifications it received since the previous call. The
 -- notifying backend PID is left out so the output is deterministic.
 set client_min_messages = warning;
-select extensions.dblink_connect(
+select public.dblink_connect(
   'pgrst_listener',
   format('host=localhost port=%s dbname=%s user=supabase_admin',
          current_setting('port'), current_database())
@@ -22,7 +22,7 @@ select extensions.dblink_connect(
  OK
 (1 row)
 
-select extensions.dblink_exec('pgrst_listener', 'LISTEN pgrst');
+select public.dblink_exec('pgrst_listener', 'LISTEN pgrst');
  dblink_exec 
 -------------
  LISTEN
@@ -32,8 +32,8 @@ create function pg_temp.pgrst_reloads() returns bigint
 language plpgsql as $$
 begin
   -- round trip so the listener has flushed any pending notification
-  perform from extensions.dblink('pgrst_listener', 'SELECT 1') as t(x int);
-  return (select count(*) from extensions.dblink_get_notify('pgrst_listener')
+  perform from public.dblink('pgrst_listener', 'SELECT 1') as t(x int);
+  return (select count(*) from public.dblink_get_notify('pgrst_listener')
           where notify_name = 'pgrst' and extra = 'reload schema');
 end $$;
 -- Setup, notifications drained below. auth, realtime and storage come from
@@ -329,7 +329,7 @@ select pg_temp.pgrst_reloads() as drop_schema;
 
 -- Cleanup
 drop schema _realtime;
-select extensions.dblink_disconnect('pgrst_listener');
+select public.dblink_disconnect('pgrst_listener');
  dblink_disconnect 
 -------------------
  OK

nix/tests/sql/pgrst_watch_triggers.sql

@@ -14,19 +14,19 @@
 
 set client_min_messages = warning;
 
-select extensions.dblink_connect(
+select public.dblink_connect(
   'pgrst_listener',
   format('host=localhost port=%s dbname=%s user=supabase_admin',
          current_setting('port'), current_database())
 );
-select extensions.dblink_exec('pgrst_listener', 'LISTEN pgrst');
+select public.dblink_exec('pgrst_listener', 'LISTEN pgrst');
 
 create function pg_temp.pgrst_reloads() returns bigint
 language plpgsql as $$
 begin
   -- round trip so the listener has flushed any pending notification
-  perform from extensions.dblink('pgrst_listener', 'SELECT 1') as t(x int);
-  return (select count(*) from extensions.dblink_get_notify('pgrst_listener')
+  perform from public.dblink('pgrst_listener', 'SELECT 1') as t(x int);
+  return (select count(*) from public.dblink_get_notify('pgrst_listener')
           where notify_name = 'pgrst' and extra = 'reload schema');
 end $$;
 
@@ -173,4 +173,4 @@ select pg_temp.pgrst_reloads() as drop_schema;
 
 -- Cleanup
 drop schema _realtime;
-select extensions.dblink_disconnect('pgrst_listener');
+select public.dblink_disconnect('pgrst_listener');