Repository navigation
fix(ami): ignore site profile library path for new cluster in pg_upgrade - #2602
Merged
Merged
Conversation
brainrake
marked this pull request as ready for review
October 28, 2026 15:32
PostgreSQL Extension Dependency Analysis: PR #2602
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2602
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Package version diff: none (aarch64-linux, x86_64-linux) |
Collaborator
|
supersedes #2601 |
mmlb
approved these changes
Oct 28, 2026
mmlb
left a comment
mmlb
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, please also bump the release version so we'll get new AMIs when merged
mmlb
force-pushed
the
fix/pg-upgrade-site-profile-libpath
branch
from
October 28, 2026 19:50
2c749eb to
8881000
Compare
Collaborator
|
Passing the config like this isn't working, it seems like $libdir is being replaced by the shell which is empty and then pg starts with empty dynamic_library_path and can't find pg_stats_statement. I'm going to go with what I had in #2601 instead of trying to deal with escape-quotes-hell. That is the temporary file so rollback on failure doesn't need any handling. |
mmlb
force-pushed
the
fix/pg-upgrade-site-profile-libpath
branch
from
October 28, 2026 21:31
8881000 to
a46d6ee
Compare
…grade Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
mmlb
force-pushed
the
fix/pg-upgrade-site-profile-libpath
branch
from
October 28, 2026 22:13
a46d6ee to
e367707
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upgrading from a 15 host with a site profile to 17 fails with
could not load library ".../site/lib/postgresql/supautils.so": undefined symbol: bms_is_empty.pg_upgrade starts the new cluster with a copy of the old cluster's
postgresql.conf. That file setsdynamic_library_pathto the site profile first, which holds the PG15 build of supautils.bms_is_emptyis an exported function in PG15 and a macro in PG16+, so PG17 cannot load that build.Introduced by supabase/postgres#2424.
What
dynamic_library_path='$libdir'. It loads the supautils in its ownpostgres-env.site-env.nix: supautils can leavepostgres-envonly afterinitiate.shand existing hosts use the site profile.