Repository navigation
Conversation
Move publish-staging and publish-prod in publish-nix-pgupgrade-*.yml and from large-linux-x86 to blacksmith-2vcpu-ubuntu-2404, matching their prepare jobs. Need to run install-nix now since blacksmith runners don't ship with it installed while large-linux-x86 did. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Dispatching "Publish nix pg_upgrade_bin flake version" with postgresVersion=15.19.0.009 failed in every publish-staging leg with "git revision '15.19.0.009' not found". postgresVersion is resolved as a git revision but would fail due to code being checked out with default shallow clone sans tags. Use the full checkout so the git show works. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Previously Release AMI Nix dispatched both publish workflows fire-and-forget, so a failed publish left the release green while upgrade scripts were missing from S3. Now we save the runids for both and watch/wait for them and bubble up any errors. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
Package version diff: none (aarch64-linux, x86_64-linux) |
mmlb
force-pushed
the
push-xvvnuuzxozpw
branch
from
October 28, 2026 22:13
42ba569 to
4f58a11
Compare
brainrake
approved these changes
Oct 29, 2026
brainrake
left a comment
brainrake
left a comment
Collaborator
There was a problem hiding this comment.
gh workflow run may fail, eg. it returns an url only if available. Moving the publishing step to a separate workflow withon: workflow_call and needs could be better here. Not blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
pg_upgrade scripts aren't being pushed correctly, failure is silent.
What is the new behavior?
AMI Release Nix waits for the triggered workflow so that if any of them fail the release fails. AMIs are still up in s3 and a re-run would fail when trying to build the AMIs but at least we have noisy failures instead of silent ones.