chore: update code comments and description

Author: acch

docs/resources/user.md

@@ -77,7 +77,7 @@ resource "forgejo_user" "non_defaults" {
 - `restricted` (Boolean) Is the user restricted?
 - `send_notify` (Boolean) Send notification to administrators? Changing this forces a new resource to be created.
 - `source_id` (Number) Numeric identifier of the user's authentication source.
-- `visibility` (String) Visibility of the user.
+- `visibility` (String) Visibility of the user. Possible values are 'public' (default), 'limited', or 'private'.
 - `website` (String) Website of the user.
 
 ### Read-Only

internal/provider/organization_action_secret_resource.go

@@ -50,7 +50,7 @@ func (m *organizationActionSecretResourceModel) from(s *forgejo.Secret) {
 		return
 	}
 
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	m.CreatedAt = types.StringValue(s.Created.Format(time.RFC3339))
 }
 

internal/provider/organization_action_variable_data_source.go

@@ -174,7 +174,7 @@ func (d *organizationActionVariableDataSource) Read(ctx context.Context, req dat
 	}
 
 	// Map response body to model
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	data.Data = types.StringValue(variable.Data)
 
 	// Save data into Terraform state

internal/provider/organization_action_variable_resource.go

@@ -46,7 +46,7 @@ func (m *organizationActionVariableResourceModel) from(v *forgejo.ActionVariable
 		return
 	}
 
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	m.Data = types.StringValue(v.Data)
 }
 

internal/provider/organization_resource.go

@@ -131,6 +131,7 @@ func (r *organizationResource) Schema(_ context.Context, _ resource.SchemaReques
 				Description: "Visibility of the organization. Possible values are 'public' (default), 'limited', or 'private'.",
 				Optional:    true,
 				Computed:    true,
+				// No static default value, because DEFAULT_ORG_VISIBILITY controls server setting
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.UseStateForUnknown(),
 				},

internal/provider/repository_action_secret_resource.go

@@ -47,7 +47,7 @@ func (m *repositoryActionSecretResourceModel) from(s *forgejo.Secret) {
 		return
 	}
 
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	m.CreatedAt = types.StringValue(s.Created.Format(time.RFC3339))
 }
 

internal/provider/repository_action_variable_data_source.go

@@ -158,7 +158,7 @@ func (d *repositoryActionVariableDataSource) Read(ctx context.Context, req datas
 	}
 
 	// Map response body to model
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	data.Data = types.StringValue(variable.Data)
 
 	// Save data into Terraform state

internal/provider/repository_action_variable_resource.go

@@ -42,7 +42,7 @@ func (m *repositoryActionVariableResourceModel) from(v *forgejo.ActionVariable)
 		return
 	}
 
-	// name is omitted here, to maintain the user's configuration casing
+	// Name is omitted here, to maintain the user's configuration casing
 	m.Data = types.StringValue(v.Data)
 }
 

internal/provider/repository_resource.go

@@ -159,7 +159,7 @@ func (m *repositoryResourceModel) from(r *forgejo.Repository) {
 	m.DefaultBranch = types.StringValue(r.DefaultBranch)
 
 	if !m.Mirror.ValueBool() {
-		// cannot archive/un-archive repository mirrors
+		// Cannot archive/un-archive repository mirrors
 		m.Archived = types.BoolValue(r.Archived)
 	}
 
@@ -178,7 +178,7 @@ func (m *repositoryResourceModel) from(r *forgejo.Repository) {
 	m.MirrorUpdated = types.StringValue(r.MirrorUpdated.Format(time.RFC3339))
 
 	if m.HasPullRequests.ValueBool() {
-		// only update PR settings if PRs are enabled
+		// Only update PR settings if PRs are enabled
 		m.IgnoreWhitespaceConflicts = types.BoolValue(r.IgnoreWhitespaceConflicts)
 		m.AllowMerge = types.BoolValue(r.AllowMerge)
 		m.AllowRebase = types.BoolValue(r.AllowRebase)
@@ -214,7 +214,7 @@ func (m *repositoryResourceModel) to(o *forgejo.EditRepoOption) {
 	o.AllowSquash = m.AllowSquash.ValueBoolPointer()
 
 	if !m.Mirror.ValueBool() {
-		// cannot archive/un-archive repository mirrors
+		// Cannot archive/un-archive repository mirrors
 		o.Archived = m.Archived.ValueBoolPointer()
 	}
 
@@ -812,6 +812,7 @@ func (r *repositoryResource) Schema(_ context.Context, _ resource.SchemaRequest,
 				Description: "Mirror interval of the repository. **Note**: This setting is only effective if `mirror` is `true`.",
 				Optional:    true,
 				Computed:    true,
+				// No static default value, because DEFAULT_INTERVAL controls server setting
 				Validators: []validator.String{
 					stringvalidator.All(
 						stringvalidator.AlsoRequires(path.Expressions{

internal/provider/user_resource.go

@@ -112,7 +112,7 @@ func (m *userResourceModel) to(s *userResourceModel, o *forgejo.EditUserOption)
 	o.FullName = m.FullName.ValueStringPointer()
 
 	if s != nil && !m.Password.Equal(s.Password) {
-		// only update password if it has changed
+		// Only update password if it has changed
 		o.Password = m.Password.ValueString()
 	}
 
@@ -253,9 +253,10 @@ func (r *userResource) Schema(_ context.Context, _ resource.SchemaRequest, resp
 				Default:     stringdefault.StaticString(""),
 			},
 			"visibility": schema.StringAttribute{
-				Description: "Visibility of the user.",
+				Description: "Visibility of the user. Possible values are 'public' (default), 'limited', or 'private'.",
 				Optional:    true,
 				Computed:    true,
+				// No static default value, because DEFAULT_USER_VISIBILITY controls server setting
 				PlanModifiers: []planmodifier.String{
 					stringplanmodifier.UseStateForUnknown(),
 				},