Approximate quadratic bezier curves with arcs and other minor improvements - #1213
Open
sivukhin wants to merge 8 commits into
Open
Approximate quadratic bezier curves with arcs and other minor improvements#1213sivukhin wants to merge 8 commits into
sivukhin wants to merge 8 commits into
Conversation
- Plugin need an file with the root SVG element at the first line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to say, that I spent a great time exploring
svgoand creating this little patch. Big thanks to all of the maintainers for this cool projectThis PR introduces several changes:
--apply-plugins-at-onceand--report-profit-after-every-passfor the sake of exploring your current configuration ofsvgoand making it more performant by tuning parameters/adding new plugins/removing useless plugins that just waste computing time. If you enable both of these options you can see the following output in your console:a.
reusePathsplugin can increasesvgoutput size if there are no elements for reuse because this plugin always add<defs/>blockb.
reusePathsplugin always expect that first element ofsvgwill be an<svg>tag, but this can be not true in case where we do not want to strip comments and meta-headerssvgo. Code forconvertPathDatalooks a little bit scary for me and my patch with new functionality looks a little bit alien in this place of code. If you think that this bit of functionality is interesting than I can try to refactor loop with filters or create a separate plugin for the type of optimization