fix: preserve inheritable defaults in referenced subtrees - #2282
Open
Neallin-917 wants to merge 1 commit into
Open
fix: preserve inheritable defaults in referenced subtrees#2282Neallin-917 wants to merge 1 commit into
Neallin-917 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2239.
When an element with an
idis instantiated through<use>, an inheritable default inside its subtree can prevent the instance from taking an unintended inherited value from the<use>context. Preserve only inheritable defaults in those subtrees; ordinary default attributes remain removable.Adds a focused regression fixture for
fill-opacity="1"beneath anidtarget used from afill-opacity=".3"context.Validation:
pnpm lintpnpm typecheckpnpm test(518 passed, 3 skipped)pnpm test:bundlesshouldHaveMismatcheddifferences and noshouldHaveMatcheddifferences in unrelated Oxygen/W3C fixtures.Disclosure: AI assistance was used to investigate and implement this contribution.