Repository navigation
fix: deduplicate subtypes before composing oneOf - #5332
Merged
Merged
Conversation
This was referenced Sep 26, 2026
ewaostrowska
force-pushed
the
pr-dedup-subtypes
branch
from
October 12, 2026 11:03
9a46889 to
25ab5a8
Compare
Contributor
|
Hi @vpelikh, thank you for the PR!
|
djankows
approved these changes
Oct 12, 2026
Identical @JsonSubTypes entries (and Jackson's AnnotationIntrospectorPair) can report the same subtype more than once. Once a polymorphic parent is composed into a oneOf (see swagger-api#5320), each duplicate entry becomes a repeated $ref in the composed schema, e.g. two $refs to the same subtype. resolveSubtypes() now drops duplicate subtypes via a new removeDuplicateSubTypes() helper, preserving declaration order.
ewaostrowska
force-pushed
the
pr-dedup-subtypes
branch
from
October 14, 2026 10:44
7765db8 to
c3e430f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Identical
@JsonSubTypesentries (and Jackson'sAnnotationIntrospectorPair) can report the same subtype more than once. Once a polymorphic parent is composed into aoneOf(see #5320), each duplicate entry becomes a repeated$refin the composed schema.resolveSubtypes()now drops duplicate subtypes while preserving declaration order.Bug fix; based on
3.0.0and independent of #5320.Related: #5320
Type of Change
Checklist
Screenshots / Additional Context
The duplicate only becomes observable once a parent is composed into a
oneOf(#5320), so the added test passes on3.0.0alone and only guards against the duplicate after #5320 lands.Merge order: both orders work, but landing this before #5320 is recommended (independent, and inert on
3.0.0).