Conversation
…e for the target while constructing our closerPeers response.
…ile responding to findNode requests
…ID and DHTPeerInfo into a single _insert and _remove
…tion from the routing table
…on peer usefulness meta data.
… raw byte values from there on out.
…deterministic and byte value comparisons work the way we expect them to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR contains fixes for our
closerPeerscalculation, wires in a peer usefulness metric, cachesPrunableMetadatavalues (instead of JSON encoding them on the fly), and refactored ourRoutingTable's add / remove peer methods.Changes:
closerPeersin responses to a.findNodequery, we consult our globalPeerStoreand prepend the peer if we know of them. Without consulting thePeerStore, we would only ever return results for otherKadDHTquery peers (peers that made it into ourRoutingTable).RoutingTableas useful when they respond to our queries with a list of closer peers. We prefer these peers over stale ones when evicting peers from ourRoutingTable.RoutingTableto handle aPeerIDandDHTPeerInfo. Now we have a single_insertmethod and a cleaner replacement strategy / eviction method.PrunableMetadatavalues every time we accessed the peers metadata. Now, we encode once, store in a static constant and compare the bytes directly.