Protobuf Update - #24
Merged
Merged
Conversation
…aceholders for swift-libp2p's outdated DHTRecord protocol signature
…ach closer peers id (cleaner log output)
btoms20
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR updated the two built in protobufs we use (DHT
Message/Recordand theIPNSEntry) and regenerated their swift counterparts.Changes:
authorandsignaturefieldsrecordfield is now theRecordtype (previously we just used bytes so we could interact with an old JS implementation)valueandsignatureV1optionalImportant
Both protobufs were generated with
proto3syntax even though the spec defines them as usingproto2. We useproto3for its enum case handling (open vs closed enums).proto3handles reasoning about an untyped / omitted enum case internally, as opposed to us having to manually check / guard against it. And as far as I understand it, they should be backwards compatible.