Fix point-scan clicks using explicit target coordinates - #775
Merged
Merged
Conversation
- Carry scan click targets through the input adapter for menu and auto selection. - Prepare macOS move and button events with explicit coordinates, modifiers, click counts and generated-event markers. - Cover stale cursor readback, native event construction and failure cleanup with tests. 🤖 Auto-generated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Point-scan clicks on macOS could use the previous cursor position because the adapter read it immediately after posting a move. Pass the selected point into native click injection and prepare the move and all button events at that point before posting any of them. Cover menu and auto-select clicks, explicit modifiers, generated-event tagging and multi-click counts. Windows retains its existing move-then-click adapter behavior.
Closes #774
Validation