Skip to content

Fix point-scan clicks using explicit target coordinates - #775

Merged
enaboapps merged 1 commit into
mainfrom
fix/point-click-target-774
Sep 15, 2026
Merged

enaboapps merged 1 commit into
mainfrom
fix/point-click-target-774

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Fix

Point-scan clicks on macOS could use the previous cursor position because the adapter read it immediately after posting a move. Pass the selected point into native click injection and prepare the move and all button events at that point before posting any of them. Cover menu and auto-select clicks, explicit modifiers, generated-event tagging and multi-click counts. Windows retains its existing move-then-click adapter behavior.

Closes #774

Validation

  • Frontend lint, 151 tests, 5 update-feed tests and production build passed.
  • Rust formatting, Clippy with warnings denied, 373 unit tests and 7 integration tests passed.
  • Fake input verifies scan click routing despite stale cursor readback and cleanup after failures. Mac tests construct native events without posting input and inspect target coordinates, ordering, flags, markers and click counts.
  • Native Mac VM/Safari: 16 button-down events at exactly (255,168) or (510,336), with the cursor moved away before each action. Covered repeated auto selection, left/right/middle/double/triple clicks and Shift/Ctrl/Alt/Command clicks; counts and modifiers matched.
  • Native Windows 11 ARM VM/Edge: 15 button-down events at exactly (640,321) or (1280,641), covering the same menu actions and repeated auto selection. Win-click delivered the expected modifier and retained the existing Start-menu-on-release behavior.
  • Restored both VMs’ scanning/switch settings and prior running states, including the previous Windows app. The signed local Mac app was not interrupted or replaced.
  • Independent review of exact head 7f5a565 found no actionable issues.

- Carry scan click targets through the input adapter for menu and auto selection.
- Prepare macOS move and button events with explicit coordinates, modifiers, click counts and generated-event markers.
- Cover stale cursor readback, native event construction and failure cleanup with tests.

🤖 Auto-generated
@enaboapps enaboapps added this to the v1.0.0-rc.10 milestone Sep 15, 2026
@enaboapps
enaboapps marked this pull request as ready for review September 15, 2026 12:01
@enaboapps
enaboapps merged commit 4c8a126 into main Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix point-scan clicks using stale cursor coordinates on macOS

1 participant