Add Close menu to every scanning page - #783
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every scanning menu page now ends with a Close menu tile. The main page pairs it with New point, subpages pair it with Back, and drag confirmation pairs it with Cancel drag. Actions keep their order in a grid of up to three columns and four rows.
Closing clears the selected points, pending request and navigation history, and leaves scanning idle without sending desktop input. Select starts a fresh point scan. Back and Cancel drag retain their existing behavior.
Closes #782
Validation on Node.js 24.13.0 and Rust 1.97.1:
npm run lint,npm test(151 frontend and 5 script tests), andnpm run buildpassed.cargo test(393 unit and 7 integration tests) passed.Independent review of latest head
4031f57a2fcc516845cbeb0547bf6bb5667acf87completed with no actionable findings. All CI checks passed, including macOS and Windows tests and packaging, frontend checks, dependency audit and CodeQL.