Skip to content

Commit a69ead2

Browse files
authored
Refactor release workflow for improved readability
1 parent 955bfd6 commit a69ead2

1 file changed

Lines changed: 17 additions & 26 deletions

File tree

.github/workflows/release.yml

Lines changed: 17 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ jobs:
1010
runs-on: ubuntu-latest
1111
env:
1212
UBUNTU_DIST: noble
13+
1314
steps:
1415
- name: Checkout
1516
uses: actions/checkout@v4
@@ -20,24 +21,17 @@ jobs:
2021
run: |
2122
sudo apt-get update
2223
sudo apt-get install -y \
23-
build-essential \
24-
cmake \
25-
ninja-build \
26-
pkg-config \
27-
gcc g++ \
28-
clang \
29-
libgtk-4-dev \
30-
libwebkitgtk-6.0-dev \
31-
libjson-glib-dev \
32-
dpkg-dev fakeroot \
33-
debhelper devscripts dput gnupg lintian
24+
build-essential cmake ninja-build pkg-config \
25+
gcc g++ clang \
26+
libgtk-4-dev libwebkitgtk-6.0-dev libjson-glib-dev \
27+
dpkg-dev fakeroot debhelper devscripts \
28+
dput gnupg lintian
3429
3530
- name: Set reusable strings
3631
id: strings
3732
shell: bash
3833
run: |
39-
echo "build-output-dir=${{ github.workspace }}/build" >> "$GITHUB_OUTPUT"
40-
# Strip a leading 'v' from tag to get the version (e.g. v1.2.3 -> 1.2.3)
34+
echo "build-output-dir=${GITHUB_WORKSPACE}/build" >> "$GITHUB_OUTPUT"
4135
TAG="${GITHUB_REF_NAME}"
4236
VERSION="${TAG#v}"
4337
echo "version=${VERSION}" >> "$GITHUB_OUTPUT"
@@ -71,7 +65,7 @@ jobs:
7165
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
7266

7367
- name: Import GPG key for PPA signing
74-
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
68+
if: ${{ secrets.GPG_PRIVATE_KEY }}
7569
env:
7670
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
7771
run: |
@@ -80,37 +74,34 @@ jobs:
8074
echo 'use-agent' >> ~/.gnupg/gpg.conf
8175
echo 'pinentry-mode loopback' >> ~/.gnupg/gpg.conf
8276
echo "$GPG_PRIVATE_KEY" | gpg --batch --yes --import
83-
echo "GPG keys imported:" && gpg --list-secret-keys --keyid-format LONG
77+
gpg --list-secret-keys --keyid-format LONG
8478
8579
- name: Prepare debian/changelog from tag
86-
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
80+
if: ${{ secrets.GPG_PRIVATE_KEY }}
8781
env:
8882
DEBEMAIL: ${{ secrets.LAUNCHPAD_EMAIL }}
8983
DEBFULLNAME: ${{ secrets.GPG_FULL_NAME }}
9084
run: |
91-
VERSION='${{ steps.strings.outputs.version }}'
92-
# Debian revision format for PPA build
93-
DEBVER="${VERSION}-0ppa1~${{ env.UBUNTU_DIST }}"
85+
VERSION="${{ steps.strings.outputs.version }}"
86+
DEBVER="${VERSION}-0ppa1~${UBUNTU_DIST}"
9487
dch --package hudbox --newversion "$DEBVER" \
95-
--distribution "${{ env.UBUNTU_DIST }}" \
88+
--distribution "$UBUNTU_DIST" \
9689
--force-distribution \
97-
"Release $VERSION for PPA (${{ env.UBUNTU_DIST }})"
90+
"Release $VERSION for PPA ($UBUNTU_DIST)"
9891
9992
- name: Build signed source package for PPA
100-
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
93+
if: ${{ secrets.GPG_PRIVATE_KEY }}
10194
env:
10295
DEBEMAIL: ${{ secrets.LAUNCHPAD_EMAIL }}
10396
DEBFULLNAME: ${{ secrets.GPG_FULL_NAME }}
10497
DEBSIGN_KEYID: ${{ secrets.GPG_KEY_ID }}
105-
DEBSIGN_GPGOPTS: --batch --yes --pinentry-mode loopback --passphrase ${{ secrets.PPA_GPG_PASSPHRASE }}
98+
DEBSIGN_GPGOPTS: "--batch --yes --pinentry-mode loopback --passphrase=${{ secrets.PPA_GPG_PASSPHRASE }}"
10699
run: |
107-
# Build source package (-S) including full source (-sa)
108100
debuild -S -sa
109-
echo "Built source changes:"
110101
ls -l ../*.changes
111102
112103
- name: Upload to Launchpad PPA
113-
if: ${{ secrets.GPG_PRIVATE_KEY != '' }}
104+
if: ${{ secrets.GPG_PRIVATE_KEY }}
114105
env:
115106
DPUT_HOST: ppa:swstegall/hudbox
116107
run: |

0 commit comments

Comments
 (0)