Skip to content

Commit be4e403

Browse files
authored
proposal: category D ("intended behavior") triage (#16)
1 parent 3c92015 commit be4e403

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

docs/Conventions/voting.md

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ tags:
77

88
Macrocosm utilizes consensus decision-making, where any contributor may create a pull request, and each Microcosm must vote on that pull request before it is merged.
99

10-
All pull requests fall under one of three categories:
10+
All pull requests fall under one of four categories:
1111

1212
* Category A: Universally Desired
1313
* Category B: Universally Agreed-on
1414
* Category C: Extreme Maintenance Burden
15+
* Category D: Intended Behavior
1516

1617
The categorization of each Pull Request is done by the triage team.
1718

@@ -33,4 +34,15 @@ Category B pull requests require agreement **with no blocking votes**; abstentio
3334

3435
This is a pull request that represents the collaborative effort between multiple Microcosms on a project that is better handled on the shared platform rather than in their respective downstreams. Potential examples of a Category C pull request would be a mechanically complex major antagonist, a complete UI rework, or other large-scale gameplay overhaul.
3536

36-
Category C pull requests require agreement **with no blocking votes**; abstentions are allowed. Category C pull requests will receive the highest scrutiny out of anything as they represent the largest risk to the overall stability of the project.
37+
Category C pull requests require agreement **with no blocking votes**; abstentions are allowed. Category C pull requests will receive the highest scrutiny out of anything as they represent the largest risk to the overall stability of the project.
38+
39+
### Category D: Intended Behavior
40+
41+
This is a pull request that fixes an unintended issue with a feature to bring it closer to its original design intent. These pull requests are considered "pre-approved", as the feature's correct design intent has already been voted on and approved in the past. Because of this, Category D pull requests can only change features added by Macrocosm.
42+
43+
Category D pull requests **do not require a vote**, only a passing code review, but any Microcosm representative may flag the pull request to be retriaged to a different category, even if they are not a code reviewer or a member of the triage team.
44+
45+
Category D does **not** apply to "subjective" changes, such as balance tweaks, unless the original value in question is blatantly contradictory to the intended design.
46+
47+
- ***Applicable:*** The metabolism delay of a species is meant to be `0.5x` as long, but was written as `2x` instead.
48+
- ***Not Applicable:*** The metabolism delay of a species is `2x` as long, but a contributor thinks this is too much and wants to make it `1.5x` instead. This would likely be Category A.

0 commit comments

Comments
 (0)