Skip to content

Commit d1c1b06

Browse files
committed
docs: scope the label recommendation, follow the font move in knip
The role table recommended the emphasized large label for chips, while the chip component set specifies the small regular label at every size - the row now names buttons alone and chips get their measured role. Knip's ignore entry moves to the ui workspace, where the fontsource packages now live and are consumed outside its JS/TS walk, and the CLAUDE.md table stops claiming knip runs as part of pnpm check.
1 parent d95ba6d commit d1c1b06

3 files changed

Lines changed: 7 additions & 8 deletions

File tree

CLAUDE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ Backend reads `DATABASE_URL` and `TEMPORAL_ADDRESS`; defaults work out of the bo
105105
| ESLint | `pnpm lint` / `pnpm lint:fix` | Per-workspace configs |
106106
| Prettier | `pnpm format` | Sorts imports via `@trivago/prettier-plugin-sort-imports` |
107107
| TypeScript | `pnpm typecheck` | Per-workspace `tsconfig.json` |
108-
| Knip | Part of `pnpm check` | Detects unused exports/dependencies |
108+
| Knip | `pnpm exec knip` | Detects unused exports/dependencies (not part of `pnpm check` or CI) |
109109
| Vitest | `pnpm test` | Runs in every workspace with a `test` script — recursive, so a new workspace is picked up automatically |
110110
| Full check | `pnpm check` | Run before PR |
111111

apps/docs/src/content/docs/ui-library/typography.mdx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ Which role to reach for:
4242
| Card or group title | `title-s`/`-m` |
4343
| Running text and descriptions | `body-m` (`body-s` for dense UI) |
4444
| Captions, helper text, metadata | `label-m`/`-l` |
45-
| Buttons and chips | `label-l-emphasized` |
45+
| Buttons | `label-l-emphasized` |
46+
| Chips (every size) | `label-s` |
4647
| Canvas node and port labels | `node-s`/`-m` |
4748
| Code, token names, IDs | `code` |
4849

knip.config.js

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,6 @@ export default {
3838
'packages/sdk': {
3939
entry: ['src/index.ts', 'src/**/*.{ts,tsx}', 'vite.config.mts'],
4040
project: ['src/**/*.{ts,tsx}', 'vite.config.mts'],
41-
// @fontsource/poppins is consumed via @import statements in src/index.css.
42-
// Knip only walks JS/TS, so it can't see the CSS reference.
43-
ignoreDependencies: ['@fontsource/poppins'],
4441
},
4542
'apps/backend': {
4643
entry: ['src/server.ts', 'drizzle.config.ts'],
@@ -58,10 +55,11 @@ export default {
5855
},
5956
'packages/ui': {
6057
entry: ['src/index.ts', 'vite.config.mts', 'scripts/check-built-css.ts'],
61-
project: ['src/**/*.{ts,tsx}', '*.mts', 'scripts/**/*.ts'],
58+
project: ['src/**/*.{ts,tsx,mts}', '*.mts', 'scripts/**/*.ts'],
6259
// Built tokens are copied by relative path (../tokens/dist) in vite.config,
63-
// so the workspace dep is real even though it is never imported by name.
64-
ignoreDependencies: ['@workflowbuilder/ui-tokens'],
60+
// and the fontsource families feed the post-build font generator - real
61+
// dependencies knip's JS/TS walk cannot see.
62+
ignoreDependencies: ['@workflowbuilder/ui-tokens', '@fontsource/poppins', '@fontsource/inter'],
6563
},
6664
'packages/tokens': {
6765
entry: ['src/index.ts'],

0 commit comments

Comments
 (0)