Add regression guard for GetServer call count in imageURL provisioning - #2165
Open
guettli wants to merge 1 commit into
Open
Add regression guard for GetServer call count in imageURL provisioning#2165guettli wants to merge 1 commit into
guettli wants to merge 1 commit into
Conversation
Counts GetServer calls in the existing full imageURL provisioning test and asserts it stays at or below the current baseline of 7, so future changes don't silently increase API call volume. Relates to #2163 # Committing as: thomas.guettler@syself.com
github-actions
Bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imageURLfull-provisioning test inpkg/services/hcloud/server/server_test.go, soGetServercalls don't silently grow beyond the current baseline of 7.GetServercall volume during provisioning, as a baseline for future work to reduce it.Relates to #2163
TODO: no e2e test for image-url provisioning
Currently, the e2e tests do not use image-url via an image-url-command. This means the number generated by the e2e tests do not reflect that kind of provisioning.