refactor(raiko): prune deprecated forks - #676
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Raiko codebase toward a Shasta-only workflow by removing deprecated fork support (Pacaya/Ontake/Hekla) across core parsing, host APIs, and utilities, and by updating stress tooling to more efficiently discover proposal boundaries.
Changes:
- Remove legacy fork/batch proving paths (including v3
/proof/batchhandler and Pacaya-related utilities/types) in favor of Shasta proposal flow. - Update Shasta stress tooling to cache anchor parsing results and use bounded/binary searches to discover proposal ranges.
- Adjust default chain specs/config/tests to reflect Shasta-focused defaults (e.g., taiko_a7 removal, verifier updates).
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| script/stress_shasta_proposal.py | Adds anchor-info caching and new boundary/proposal-group discovery logic; updates Raiko submission context. |
| script/prove-shasta.sh | Updates usage text to reference taiko_hoodi instead of taiko_a7. |
| reqactor/src/backend.rs | Removes legacy batch-request Raiko construction (now hard-errors). |
| lib/src/utils/txs.rs | Drops Pacaya tx generation; Shasta-only batch tx generation. |
| lib/src/utils/pacaya.rs | Deletes Pacaya tx generation implementation. |
| lib/src/utils.rs | Removes pacaya module export. |
| lib/src/protocol_instance.rs | Removes non-Shasta protocol-instance logic; Shasta-only batch instance hashing/verification remains. |
| lib/src/input/{pacaya,ontake,hekla}.rs | Deletes deprecated fork ABI/input definitions. |
| lib/src/input.rs | Makes BlockProposedFork Shasta-only; prunes legacy fork-specific helpers. |
| lib/src/consts.rs | Updates fork/verifier tests and adds assertions for shasta-only defaults. |
| host/src/server/api/v3/proof/mod.rs | Removes legacy batch handler routes/docs; keeps Shasta batch endpoint. |
| host/src/server/api/v3/proof/batch_handler.rs | Deletes legacy v3 batch handler. |
| host/src/server/api/v3/proof/batch/pacaya.rs | Deletes Pacaya batch request processing helper. |
| host/src/server/api/v3/proof/batch/mod.rs | Removes Pacaya batch module export. |
| host/config/config.taiko_hoodi.json | Removes legacy fork SGX instance-id entries. |
| host/config/chain_spec_list_default.json | Removes Holesky + taiko_a7; prunes PACAYA L1 contract entries; adds/keeps hoodi + shasta taiko networks. |
| core/src/preflight/util.rs | Removes single-block + Pacaya preflight paths; Shasta-only event decode/filter behavior. |
| core/src/preflight/mod.rs | Stops exporting Pacaya batch proposal parsing entrypoint. |
| core/src/preflight/lru.rs | Makes test-only cache-clear helper #[cfg(test)]. |
| core/src/lib.rs | Removes Pacaya batch proving tests; adds a Shasta fixture regression test. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 48 out of 49 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 65 out of 68 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
host/src/server/api/v3/proof/report.rs:18
- OpenAPI annotation declares
postfor/proof/report, but the router registers this handler withrouting::get. This will generate incorrect API docs/clients; update the#[utoipa::path(...)]method toget(or change the route).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 85 out of 87 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ly mode - Removed all references to the pacaya fork, including related functions and test cases. - Updated the tests to ensure compatibility with shasta-only specifications. - Adjusted chain specifications to reflect the removal of pacaya and ensure proper handling of shasta proposals. - Cleaned up unused imports and code related to pacaya processing in various modules.
- core: extract helpers (build_batch_blocks, verify_parent_hash_chain, get_prover_config), fix EventFilterConditioin typo, add constants - lib: extract reth_chain_spec_for_name, active_fork_spec_id, simplify matches!/clamp/is_empty, dedupe keccak in mpt, add docs Made-with: Cursor
Made-with: Cursor
- Removed unused BatchMetadata and BatchProofRequest structs from interfaces.rs. - Simplified various function implementations and improved readability across multiple files. - Adjusted logging statements for better clarity and consistency. - Enhanced type handling and reduced complexity in preflight and provider modules. Made-with: Cursor
- Added patterns for .env files, log files, and patch files to .gitignore. - Updated submodule reference for gaiko.
- Removed AggregationGuestInput and its associated handling from multiple files, including interfaces, prover, and SGX modules. - Updated Dockerfile to exclude the boundless aggregation binary. - Cleaned up environment variable configurations in sample files. - Streamlined the entrypoint script by removing unnecessary instance ID updates. - Adjusted test imports to reflect the removal of aggregation input handling. This refactor simplifies the codebase by eliminating unused components and improving overall clarity.
- Changed L1_NETWORK references from "holesky" to "hoodi" in various configuration files, scripts, and documentation. - Updated environment variable configurations in .env files and Docker Compose files to reflect the new L1 network. - Adjusted related scripts to ensure compatibility with the new network naming. This update aligns the codebase with the current network naming conventions and improves clarity in configuration settings.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 126 out of 128 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
host/src/server/api/v3/proof/list.rs:17
- This handler is wired into the router but still calls
todo!(), which will panic on the first request to/v3/proof/list(and/proof/list). Either implement the listing logic or remove/disable the route until it’s ready (e.g., return a structured error response instead of panicking).
host/src/server/api/v3/proof/report.rs:85 - The OpenAPI annotation declares this as
POST /proof/report, but the actual router registersGET /proof/report. This mismatch will generate incorrect docs/clients; update the#[utoipa::path(...)]method toget(or change the router topost) so the spec matches runtime behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 126 out of 128 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
host/src/server/api/v3/proof/report.rs:86
- The OpenAPI annotation declares this endpoint as
post(#[utoipa::path(post, ...)]), but the router registers it withget(report_handler). This will generate incorrect API docs / client bindings; update theutoipa::pathmethod togetto match the actual route.
host/src/server/api/v3/proof/list.rs:17 list_handleris wired into the router but still containstodo!(), which will panic and return 500 on any request. Either implement the listing behavior now, or return an explicit “not implemented” response (e.g., a structuredStatus::Error/ 501) until it’s ready.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.