This repository was archived by the owner on Aug 3, 2026. It is now read-only.
fix: bound batch preflight retries and timeouts - #683
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens batch preflight/proving execution against upstream stalls by introducing bounded RPC timeouts/retries and top-level request timeouts, so tasks fail explicitly instead of hanging indefinitely.
Changes:
- Add per-request backend timeouts (env-configurable) so guest input/proof/aggregation jobs transition to
Failedon stalls. - Add RPC client connect/request timeouts plus bounded retry w/ exponential backoff for batched RPC fetching in preflight.
- Make SP1 network
wait_prooftimeout configurable and add an early batch preflight log line before RPC fetching.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| reqactor/src/backend.rs | Wraps each request execution in a tokio::time::timeout with env-configurable durations to prevent stuck jobs. |
| provers/sp1/driver/src/lib.rs | Replaces hard-coded SP1 network wait timeout with an env-configurable function. |
| core/src/provider/rpc.rs | Introduces RPC client timeouts and a retry helper, applying it to batched block/account/storage/proof fetches. |
| core/src/preflight/mod.rs | Adds a log line before the first batch preflight RPC fetch for better observability. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
smtmfft
approved these changes
Apr 1, 2026
smtmfft
approved these changes
Apr 1, 2026
smtmfft
left a comment
Contributor
There was a problem hiding this comment.
I think retry isn’t essential (though it doesn’t hurt), as the first timeout error will be caught by the task DB, and a new task will be triggered later by following client requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Registered.How
Failed.Tests
cargo fmt --allcargo check -p raiko-reqactor --features sp1cargo check -p raiko-host --features sp1