This repository was archived by the owner on Aug 3, 2026. It is now read-only.
refactor: improve batch preflight processing with enhanced indexing - #690
Merged
Conversation
- Introduced a `batch_block_offset` to track the starting index of each task batch. - Updated the transaction processing loop to include the batch index for the first block in a proposal, ensuring compliance with Shasta anchor rules. - Enhanced the `RethBlockBuilder` initialization to reflect whether the current block is the first in the proposal batch.
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors batch preflight execution to correctly track each block’s position within the overall proposal batch (even when processed in parallel chunks), so Shasta-specific “first block” anchor rules are applied only where intended.
Changes:
- Introduces a cross-chunk
batch_block_offsetto compute a stable global batch index per block. - Updates the per-block processing loop to derive
batch_block_idxand passis_first_block_in_proposalintoRethBlockBuilder.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johntaiko
approved these changes
Apr 29, 2026
smtmfft
added a commit
that referenced
this pull request
May 21, 2026
…690) - Introduced a `batch_block_offset` to track the starting index of each task batch. - Updated the transaction processing loop to include the batch index for the first block in a proposal, ensuring compliance with Shasta anchor rules. - Enhanced the `RethBlockBuilder` initialization to reflect whether the current block is the first in the proposal batch. (cherry picked from commit 7856bc0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
batch_block_offsetto track the starting index of each task batch.RethBlockBuilderinitialization to reflect whether the current block is the first in the proposal batch.