Skip to content
This repository was archived by the owner on Aug 3, 2026. It is now read-only.

chore: port hotfix branch changes to main - #695

Closed
smtmfft wants to merge 8 commits into
mainfrom
port/hotfix-key-build-to-main
Closed

chore: port hotfix branch changes to main#695
smtmfft wants to merge 8 commits into
mainfrom
port/hotfix-key-build-to-main

Conversation

@smtmfft

@smtmfft smtmfft commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Port the hotfix branch commits onto main: anchor-failure dependency updates, lockfile updates, taiko-reth bump, gaiko bump, batch preflight indexing refactor, and enclave signing-key build hardening.
  • Remove the committed enclave signing key from the repo/image build path and require BuildKit secrets for release signing keys.
  • Keep main's deprecated-fork test pruning during conflict resolution; the old hotfix-only tests were not reintroduced.

Notes

Verification

  • bash -n script/publish-image.sh
  • git diff --check origin/main...HEAD
  • rustfmt --edition 2021 --check core/src/lib.rs lib/src/consts.rs
  • cargo test -p raiko-lib --features=std consts::tests::raiko_active_fork
  • Docker fail-closed smoke: build-gaiko fails when ENCLAVE_KEY_PUBLIC_SHA256 is set without an enclave-key secret.
  • Docker positive smoke: build-gaiko succeeds with a temporary RSA-3072/e=3 key passed via BuildKit secret and matching public-key hash.

smtmfft and others added 6 commits June 25, 2026 18:36
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
Signed-off-by: smtmfft <smtm@taiko.xyz>
…690)

- Introduced a `batch_block_offset` to track the starting index of each task batch.
- Updated the transaction processing loop to include the batch index for the first block in a proposal, ensuring compliance with Shasta anchor rules.
- Enhanced the `RethBlockBuilder` initialization to reflect whether the current block is the first in the proposal batch.
* fix: keep enclave signing key out of image builds

* fix: support GCP Secret Manager enclave key

* chore: update mainnet SGX verifier addresses

* chore: update gaiko submodule verifier config

* chore: update internal devnet chain spec

* fix: align devnet SGX verifier addresses

* fix: restore devnet verifier config

* fix: align gaiko embedded chain specs

* fix: remove invalid shasta chain spec forks

* fix: unblock enclave key CI build
Copilot AI review requested due to automatic review settings June 25, 2026 10:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.

Comment thread Dockerfile
Comment on lines +20 to +30
if [ -s /run/secrets/enclave-key.pem ]; then \
if [ -n "${ENCLAVE_KEY_PUBLIC_SHA256}" ]; then \
test "$(openssl rsa -in /run/secrets/enclave-key.pem -pubout 2>/dev/null | openssl sha256 | awk '{print $2}')" = "${ENCLAVE_KEY_PUBLIC_SHA256}"; \
fi; \
cp /run/secrets/enclave-key.pem private.pem; \
else \
test -z "${ENCLAVE_KEY_PUBLIC_SHA256}"; \
openssl genrsa -3 -out private.pem 3072; \
fi; \
ego sign && \
ego bundle gaiko-ego gaiko
Comment thread Dockerfile
Comment on lines +113 to 124
if [ -s /run/secrets/enclave-key.pem ]; then \
if [ -n "${ENCLAVE_KEY_PUBLIC_SHA256}" ]; then \
test "$(openssl rsa -in /run/secrets/enclave-key.pem -pubout 2>/dev/null | openssl sha256 | awk '{print $2}')" = "${ENCLAVE_KEY_PUBLIC_SHA256}"; \
fi; \
cp /run/secrets/enclave-key.pem "$enclave_key_path"; \
else \
test -z "${ENCLAVE_KEY_PUBLIC_SHA256}"; \
openssl genrsa -3 -out "$enclave_key_path" 3072; \
fi; \
gramine-manifest -Dlog_level=error -Ddirect_mode=0 -Darch_libdir=/lib/x86_64-linux-gnu/ ../provers/sgx/config/sgx-guest.local.manifest.template sgx-guest.manifest && \
gramine-sgx-sign --key "$enclave_key_path" --manifest sgx-guest.manifest --output sgx-guest.manifest.sgx && \
gramine-sgx-sigstruct-view "sgx-guest.sig" 2>&1 | tee /tmp/sgx_sigstruct.log
@smtmfft

smtmfft commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by a narrower PR from current main that only keeps the enclave-key build hardening. This branch is stale/conflicting and would rewind newer Shasta/gaiko/chainspec changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants