Fix native ESM config loading in v3 - #18938
Merged
Merged
Conversation
thecrypticace
force-pushed
the
fix/esm-fixes
branch
3 times, most recently
from
September 15, 2025 20:46
a087363 to
c37f9c0
Compare
thecrypticace
commented
Sep 15, 2025
thecrypticace
marked this pull request as ready for review
September 15, 2025 21:01
thecrypticace
force-pushed
the
fix/esm-fixes
branch
2 times, most recently
from
September 16, 2025 16:12
9aa5207 to
a3eab0d
Compare
RobinMalfait
approved these changes
Sep 16, 2025
RobinMalfait
left a comment
RobinMalfait
left a comment
Member
There was a problem hiding this comment.
Looks good, but I think we can drop that extension check.
Jiti hotfixed the incompatibility in 1.21.7 so we can safely drop this code. This fixes an issue where `import.meta.*` can’t be used at all. At least with this newer node versions that support `require(esm)` *can* even if top-level await isn’t usable. Unfortunately switching this to import(…) and thus returning a promise is a breaking change for IntelliSense, Prettier, and any other potential clients using the public `loadConfig` API.
thecrypticace
force-pushed
the
fix/esm-fixes
branch
from
September 16, 2025 17:26
a3eab0d to
a1dffac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately for backwards compatibility purposes (with
loadConfigat least) we can't switch things to useimport(…)because there's baked in knowledge that the config is loaded synchronously for v3.This PR does two things:
require(…)which allows newer versions that supportrequire(esm)to work natively. This works around the need to switch toimport(…)for those versions.postcss-load-configenabling better ESM+TypeScript support for PostCSS configs in the CLI.We support v4, v5, and v6 of
postcss-load-configsimultaneously so any of those versions should work. I've verified that newer node versions seem to install v6 while earlier ones like Node v14 install v4 ofpostcss-load-config. So this should be a backwards compatible change.import.meta.resolve(…)Fixes #14152
Fixes #14423