Fix extraction of quoted arbitrary variants in v3 - #20374
Merged
RobinMalfait merged 4 commits intoAug 3, 2026
Conversation
Contributor
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (3): Last reviewed commit: "update comment" | Re-trigger Greptile |
RobinMalfait
force-pushed
the
fix/v3-extractor-variant-order
branch
from
August 3, 2026 13:55
a91f489 to
53e8210
Compare
RobinMalfait
enabled auto-merge (squash)
August 3, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18387.
The v3 default extractor did not capture the complete candidate when a standard variant preceded an arbitrary selector containing quoted values, such as
focus-visible:[&:not([aria-selected="true"])]:bg-red-500.The quote-aware pattern allowed quote characters in the standard-variant portion, causing extraction to begin at the surrounding
classorclassNameattribute and split the candidate. This change excludes single and double quotes from that portion of the pattern while continuing to allow quotes inside arbitrary variants.Regression tests cover both single- and double-quoted selectors with preceding
focus-visibleandhovervariants.[ci-all]
Test plan
npx jest tests/default-extractor.test.js tests/arbitrary-variants.test.js --runInBandnpm test -- --runInBandResults: