Repository navigation
chore(chat): 精简会话页菜单——删「结束讨论」与「分享对话卡片」两个冗余项 - #21
Merged
Merged
Conversation
- 结束讨论 (end group chat): the group-chat banner already carries the same endGroupChat() button, always visible while a group chat runs and one tap away. The overflow entry was enabled only in exactly that state, yet needed two taps to reach the same call — a pure duplicate. Banner button stays; menu entry goes. - 分享对话卡片 (share conversation card): the session list already exports conversations (JSON / plain text / ZIP). Rendering a conversation into a shareable card image is a second, lower-value sharing path, and the overflow menu is a known overload root cause (16+ entries). Entry, dialog, VM function, ConversationCardShare implementation and its test removed (~390 lines).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
依据
结束讨论(菜单项):群聊横幅上已有同一个
endGroupChat()按钮(ChatScreen 2986),群聊开启时常驻可见、一步可达;菜单项enabled = groupChatOn——只在群聊开启时可用,而那正是横幅在屏幕上的时候。两步菜单路径完全被一步横幅按钮覆盖,纯重复入口。删菜单项,横幅按钮保留。分享对话卡片:会话列表已有完整导出(JSON/纯文本/ZIP,SessionListScreen 1832-1850)覆盖"把会话内容拿出去";渲染成卡片图片是第二条低价值分享路径。且会话页溢出菜单 16+ 项过载是已确认的"凌乱"根因,砍低频项是净收益。
删除范围
测试
本机无 JDK,编译与全量单测交 CI。