Skip to content

Commit 045cac7

Browse files
committed
Verify retained provider failures after notification dismissal
1 parent dd30c76 commit 045cac7

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

‎packages/cli/tests/repl-sidekick-lifecycle.test.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -951,6 +951,14 @@ describe("Tier PV — generation that ended without a reply", () => {
951951
].join("\n"),
952952
];
953953

954+
const NOTICE = "Sidekick reply failed";
955+
956+
function* dismissFailureNotice(page: ReplPage): Operation<void> {
957+
yield* page.until("the provider failure notification", (one) => one.shows(NOTICE));
958+
yield* page.key("Escape");
959+
yield* page.until("the dismissed failure notification", (one) => !one.shows(NOTICE));
960+
}
961+
954962
it("PV3: a provider that fails after saying something leaves an unfinished attempt", function* () {
955963
const page = yield* useReplPage();
956964
const repl = page.repl;
@@ -967,6 +975,7 @@ describe("Tier PV — generation that ended without a reply", () => {
967975

968976
// The saved failed turn is the account now: said as unfinished, with the
969977
// literal Output it had managed and the reason it stopped.
978+
yield* dismissFailureNotice(page);
970979
yield* page.until("the unfinished attempt", (one) =>
971980
one.shows(`${MOUNTED_AGENT} (unfinished)`),
972981
);
@@ -1127,6 +1136,7 @@ describe("Tier PV — generation that ended without a reply", () => {
11271136

11281137
// Both items stand: the reply that was answered and the attempt that was
11291138
// not. Drawing them is what a duplicated row would have crashed.
1139+
yield* dismissFailureNotice(page);
11301140
yield* page.until("the failed successor", (one) => one.shows("(unfinished)"));
11311141
expect(repl.outcome()).toBe(undefined);
11321142
expect(page.screen().shows("First reply.")).toBe(true);
@@ -1156,6 +1166,7 @@ describe("Tier PV — generation that ended without a reply", () => {
11561166
first.fake.script({ deltas: CANDIDATE, stopReason: "refusal" });
11571167

11581168
yield* sendMessage(firstPage, "try it");
1169+
yield* dismissFailureNotice(firstPage);
11591170
yield* firstPage.until("the unfinished attempt", (one) =>
11601171
one.shows(`${MOUNTED_AGENT} (unfinished)`),
11611172
);
@@ -1182,6 +1193,7 @@ describe("Tier PV — generation that ended without a reply", () => {
11821193
// process remembered: this command never saw that generation.
11831194
expect(againPage.screen().shows("As far as I")).toBe(true);
11841195
expect(againPage.screen().shows("(preview)")).toBe(false);
1196+
expect(againPage.screen().shows(NOTICE)).toBe(false);
11851197
// Reading it cost nothing: no turn, no session, not one byte.
11861198
expect(againPage.repl.fake.prompts).toHaveLength(asked);
11871199
expect(againPage.repl.fake.ensured).toHaveLength(opened);

0 commit comments

Comments
 (0)