Repository navigation
Commit 787ebcb
authored
💥 Say where components come from with --include (#631)
* 💥 Say where components come from with --include
Rename the configured component-search-path surface: `includes` at every
programmatic boundary, `--include` as the repeatable CLI flag, and
`DEFAULT_INCLUDES` for the exported `["components", "."]` default.
This is a clean break. No alias, no deprecation, no compatibility parser:
the typed API no longer declares the former member, and an untyped object
carrying it is not read.
"Component search path" and "component search directory" stay the names of
the complete ordered resolution path and of one directory on it. Includes
name only the configured contribution to that path.
Resolution order, diagnostics, the `searched` list, journal shape, the
workflow's empty contribution and directory-target composition are
unchanged.
Refs #271
* 🚫 Refuse the flag --include replaced
The argument parser ignores options it does not define rather than
rejecting them, so `--component-dir` was silently dropped: a run searched
the defaults and either failed somewhere unrelated or succeeded while
ignoring where the caller said components come from.
`xmd run` and `xmd test` now refuse it by name, before the run resolves
its props and before a test target is discovered. Both spellings are
refused — the separated value and the `=` form — and tokens after `--`
still belong to the document.
This is a refusal, not an alias: no value is mapped, and no generic
unknown-option policy is introduced. The retired spelling is assembled
from fragments at its one remaining site, so the migration audit stays
empty.
Refs #271
* 🐛 Read the refusal from what the parser did not consume
A directory can be named after the retired flag, and naming a directory
is what --include is for. Scanning raw argv read that value as an option
and refused the run — the one caller using the new option correctly.
The finder now reads the parser's leftovers, where a token consumed as a
value no longer appears. The end-of-options separator survives into those
leftovers, so a retired spelling after -- still belongs to the document.
Refs #271
* 🎨 Reflow the docs list item the shorter flag changed
`deno fmt` owns `site/`, and the option name lost eight characters, so the
line it was wrapped for now fits differently.
* 🔥 Drop the retired include flag rather than refuse it
Nothing has been released that names the old flag, so there is no caller
to tell. The refusal existed only to answer one, and it cost a constant
assembled from fragments to keep the migration audit empty — a string the
one place that handled it could not be searched for.
The old spelling is now an option xmd does not define, exactly like any
other typo, and no code in the repository mentions it.
Refs #271
* 🔥 Stop asserting the absence of names nothing can name
CR35 and CR38 proved the retired option was gone from the typed surface
and unread at runtime, and CR36 proved the retired export was gone. With
the old spelling deleted rather than deprecated there is nothing to be
absent from: the audit already says no source mentions it, and a test
that spells it from fragments only reintroduces the name it checks for.
CR36 keeps what is a claim about the present surface — the default value,
and that core exports it.
Refs #271
---------
Co-authored-by: Taras Mankovski <74687+taras@users.noreply.github.com>1 parent 0e88e91 commit 787ebcb
62 files changed
Lines changed: 320 additions & 220 deletions
File tree
- .github/workflows
- packages
- cli
- src
- tests
- support
- core
- src
- components
- tests
- test-agent/tests
- testing/tests
- web/tests
- workflow/tests
- scripts
- tests
- site/routes/docs
- specs
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
190 | | - | |
| 189 | + | |
| 190 | + | |
191 | 191 | | |
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
195 | 195 | | |
196 | | - | |
197 | | - | |
| 196 | + | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
239 | 239 | | |
240 | 240 | | |
241 | 241 | | |
242 | | - | |
| 242 | + | |
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
| |||
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
382 | | - | |
| 382 | + | |
383 | 383 | | |
384 | 384 | | |
385 | 385 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
51 | | - | |
52 | | - | |
53 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | | - | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2893 | 2893 | | |
2894 | 2894 | | |
2895 | 2895 | | |
2896 | | - | |
| 2896 | + | |
2897 | 2897 | | |
2898 | 2898 | | |
2899 | 2899 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
| 167 | + | |
168 | 168 | | |
169 | 169 | | |
170 | 170 | | |
| |||
226 | 226 | | |
227 | 227 | | |
228 | 228 | | |
229 | | - | |
| 229 | + | |
230 | 230 | | |
231 | 231 | | |
232 | 232 | | |
| |||
538 | 538 | | |
539 | 539 | | |
540 | 540 | | |
541 | | - | |
| 541 | + | |
542 | 542 | | |
543 | 543 | | |
544 | 544 | | |
| |||
662 | 662 | | |
663 | 663 | | |
664 | 664 | | |
665 | | - | |
666 | | - | |
| 665 | + | |
667 | 666 | | |
668 | 667 | | |
669 | 668 | | |
| |||
744 | 743 | | |
745 | 744 | | |
746 | 745 | | |
747 | | - | |
| 746 | + | |
748 | 747 | | |
749 | 748 | | |
750 | 749 | | |
| |||
758 | 757 | | |
759 | 758 | | |
760 | 759 | | |
761 | | - | |
| 760 | + | |
762 | 761 | | |
763 | 762 | | |
764 | 763 | | |
| |||
972 | 971 | | |
973 | 972 | | |
974 | 973 | | |
975 | | - | |
| 974 | + | |
976 | 975 | | |
977 | 976 | | |
978 | 977 | | |
| |||
1829 | 1828 | | |
1830 | 1829 | | |
1831 | 1830 | | |
1832 | | - | |
| 1831 | + | |
1833 | 1832 | | |
1834 | 1833 | | |
1835 | 1834 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
84 | 85 | | |
85 | 86 | | |
86 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
| 204 | + | |
205 | 205 | | |
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
210 | 230 | | |
211 | 231 | | |
212 | 232 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | | - | |
| 65 | + | |
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
| |||
0 commit comments