Skip to content

Run independent review when a PR is ready for delivery #1346

Open

Description

@taras

Problem

Delivery currently offers independent review whenever implementation feedback matches a new commit and no independent verdict exists for that SHA. This repeats the expensive review while the Implementor is still incorporating Planner and Architect feedback or fixing CI.

Desired workflow

  1. Keep the PR in draft during implementation, internal feedback and CI fixes.
  2. Submit the completed delivery candidate for one independent review after Planner and Architect feedback is resolved and the required checks are green. Pin the candidate SHA so the recorded verdict names exactly what was reviewed.
  3. If Independent Review requests changes, apply the findings, verify the revised candidate, and send it back to Independent Review. Keep the draft in that repair loop until a PASS.
  4. After PASS and green required checks for the candidate, publish the review result through the normal delivery path and mark the PR ready for review. Merging remains a separate action.

Acceptance

  • Ordinary pushes, status checks, CI retries and Planner or Architect repair commits do not start another independent review. Advancing a draft candidate before it is submitted creates no independent-review call.
  • One concurrent delivery candidate produces one independent-review call. A changes-required verdict permits a new call after the repair candidate is submitted. Repeated status or ready actions reuse the recorded PASS.
  • When the head changes in flight, retain the verdict on the reviewed SHA and surface the change for an explicit delivery decision. A push alone does not dispatch a reviewer or silently attach that verdict to different code.
  • Preserve reviewer fallback and recovery. Cover interim commits, candidate submission, changes required and repaired, PASS with green CI, and duplicate delivery calls through the workflow entry point.

Coordinate with #1323 / #1324, which own publishing validated independent-review comments.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions