Repository navigation
Conversation
This was referenced Nov 16, 2026
taras
force-pushed
the
codex/publish-independent-review-1323
branch
from
November 16, 2026 02:18
34692e2 to
c4a4fad
Compare
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Delivery already retained the validated independent review, but a person had to copy its result to the pull request. A missing comment could leave maintainers without the evidence behind a repair or merge decision.
What changes
delivery.mdpublishes every validated exact-head verdict through GitHub’s issue comments API and uses<PullRequest.Comments>for reconciliation and readback. The native GitHub provider reads repositories listed in the host’sXMD_WORKFLOW_GITHUB_PULL_REQUESTSconfiguration. The comment shows the reviewed commit, effective reviewer, verdict, summary, and findings. Readiness and repair handoff wait until GitHub returns the matching comment and Delivery saves its URL with the reviewed SHA.--props-action publish-reviewreconciles from the saved review. Concurrent invocations using the same delivery record share a write reservation for the PR and commit. If GitHub may have accepted an interrupted write, a retry looks for the exact comment before any further action.statusandcloseoutread GitHub and report the gate.Review guide
examples/adversarial-implementation/delivery.mdandcomponents/Delivery/Status.mdfor the entrypoint and readiness gate.components/Delivery/ReviewPublication.mdfor the native comment reads andcomponents/Delivery/ReviewComment.tsfor the target check, write reservation, and comment verification.tests/DeliveryPublication.test.mdfor overlapping invocations and an accepted write whose acknowledgement is lost.How to verify it
deno task test examples/adversarial-implementation/tests/DeliveryPublication.test.mdThe test drives the Delivery entrypoint with controlled ACP and GitHub boundaries. It covers passing and changes-required verdicts, the effective Astra fallback, a stale PR head, unavailable native comment reads, concurrent publication, and readback after an accepted write with a lost acknowledgement. The retry proves that neither ACP nor the comment write runs again.
Closes #1323.