Repository navigation
Conversation
Move packages/core/src/agent into the new publishable @executablemd/agent package with ./api and ./host entries, and remove every Agent export from Core's root, API and host. Agent production code reaches Core only through its public entries; Core's host gains the narrow failure, source-owner and approved-copy placement helpers that requires. Registrations, identity components and documentation keep the @executablemd/core origin and the synthetic conversation root is unchanged. Migrate CLI, ACP, Workflow, Test Agent, examples and tests to the new entries, move the Agent suites and PA4 into the package, add the package boundary tests, and update manifests, locks, packaging, the publish workflow, specs, architecture and the README map. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The nested-run inspection host built its Plugin source with Agent imported from Core's root, which no longer exports it. The documentation smoke's closing line now names both packages it documents. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PB1 now reads `deno info` through the scoped quiet-process pattern, so a passing run no longer forwards megabytes of graph JSON, and its one predicate covers the registry spellings (npm, JSR and jsr.io) beside the local Agent paths. The npm CLI artifact suite asserts the emitted Core manifest has no Agent dependency and that a consumer outside the checkout imports both Agent subpaths through the emitted export map. The release specification records Agent's publish order, its relocated documentation asset and the new npm check. The language spec states the documentation join by registered origin and why Agent keeps the Core origin; the ACP and launch specs name the Agent package as the owner of configured uses, setup snapshots and the delivered launch coordinator, with phases retained under Core-issued invocation identity. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
taras
marked this pull request as ready for review
November 15, 2026 23:03
taras
merged commit Nov 15, 2026
56b5af5
into
codex/sidekick-reply-approval-correction
1 check passed
taras
added a commit
that referenced
this pull request
Nov 16, 2026
Restack the reviewed #1327 reply approval feature (tree delta 853e862..35dcb34, previously at 88703be) onto main after the Agent package extraction (#1343), without the #1337 extraction spike. Agent owns the conversation, reply review, acceptance record and replay (packages/agent/src/reply-acceptance.ts, reply-review.ts, exported from @executablemd/agent/host). Core keeps the generic pieces the feature needs: the accepted-reply copy grants, reply secret location and text checks, Elicit answer readers, and executeInstalledBound with the evaluator that takes an AcceptedRootReply, all exported from @executablemd/core/host. Core imports nothing from the Agent package. The approval drawer takes precedence over main's Sidekick inspection view, and the chat projection keeps both main's request reading and the feature's control outcomes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sidekick reply acceptance needs permission to save specific text that secret detection flagged. This spike tests whether Core can provide that permission to any trusted host while the host owns the approval decision and the meaning of its record.
What changes
Sidekick asks for approval within its existing turn continuation. On acceptance it calls the scoped
approveAppend()operation and publishes the reply using the ordinary durable operation. The approval names the coroutine, effect, exact string fields, and approved finding ranges. The journal still scans the entire append and requires every finding to match.The trusted host receives the operation alongside the execution handle. Grant registration now travels directly to its owner, outside replaceable Context. The scope retires the grant, and journal replay restores the acknowledged record without asking for approval again.
Review guide
Start with
packages/core/tests/append-approval.test.tsto see a host with no Agent dependency. Then followapproveAppend()inpackages/core/src/secrets/append-approval.tsand its Sidekick caller inpackages/core/src/agent/conversation.ts.How to verify it
3a2b2264cpassed on Deno (167 steps across four suites), Node (94 tests), and Bun (94 tests).Scope
This draft is stacked on #1327 so the diff shows only the spike. Generated evaluation and automatic feedback still use Agent-specific provenance logic. The generic append approval is the seam tested here.