Skip to content

Inspect Sidekick exchanges and recorded XMD feedback - #1340

Merged
taras merged 3 commits into
mainfrom
codex/repl-sidekick-inspection-931
Nov 16, 2026
Merged

taras merged 3 commits into
mainfrom
codex/repl-sidekick-inspection-931

Conversation

@taras

@taras taras commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

REPL UI evidence

Checkpoint Fixture Viewport Action Reference Before After Comparison
journey-3-160x36 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 160 × 36 Open the attributed control-result feedback row at 160x36. Reference journey-3-160x36 Before journey-3-160x36 After journey-3-160x36 match
journey-6-160x36 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 160 × 36 Open Round 1 feedback and expand the recorded packet at 160x36. Reference journey-6-160x36 Before journey-6-160x36 After journey-6-160x36 match
journey-7-160x36 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 160 × 36 Open the final reply exchange at 160x36. Reference journey-7-160x36 Before journey-7-160x36 After journey-7-160x36 match
journey-5-72x20 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 72 × 20 Open collapsed Round 1 result feedback in the narrow Sidekick drawer at 72x20. Reference journey-5-72x20 Before journey-5-72x20 After journey-5-72x20 match
journey-7-120x30 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 120 × 30 Open the final reply exchange at 120x30. Reference journey-7-120x30 Before journey-7-120x30 After journey-7-120x30 match
saved-turn-2-160x36 Identical scripted ACP REPL.Environment, EntryInput/Submit of Entry 1, and final Output on base b7d8fe2 and head d5a26f5; accepted v8 #4329b607 reference. 160 × 36 Select saved Turn 2 from the exchange at 160x36. Reference saved-turn-2-160x36 Before saved-turn-2-160x36 After saved-turn-2-160x36 match

Mounted typing latency

Viewport 200 × 52. Milliseconds from character dispatch to the completed emulator write containing the changed Message value.

Workload Samples per run Before median After median Δ median Before p95 After p95 Δ p95
small 30 11.270 10.998 -0.272 12.275 11.751 -0.524
wrapping 30 17.377 18.731 1.354 19.001 19.942 0.940

Why

A Sidekick request can produce several saved turns while it reads a control result, runs an entry, and replies. The Transcript used the same person marker for automatic feedback, which made it hard to tell what a person said and what XMD sent.

What changes

The Transcript groups the saved turns under one Sidekick exchange. XMD feedback has its own attributed row. Select it to inspect the recorded feedback and the linked entry. The exchange also opens individual saved turns with their recorded origin. At 72 × 20 the same details open in the Sidekick drawer.

The inspection reads the existing retained records. The scripted journey reopens the saved session and sees the same exchange and entry once.

How to verify it

  • The ReplBench conversation journey runs a real scripted request, reads REPL.Environment, submits one entry, receives its actual output, and prints the final Sidekick reply.
  • The journey opens recorded feedback, saved Turn 2, and the 72-column drawer. Cold reopen verifies the history once and opens the same recorded feedback again.
  • The paired Reference, Before, and After evidence compares the exchange and inspector at 160, 120, and 72 columns. The mounted typing report uses the same pinned base and candidate.

Part of #931.

taras commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

Independent review

PASS on 3262aa00651483e10f7a64e35bf3d1f6e9816d38 against 80386e66e71b870dd1bf5340f140d6b2e5e8c9fa. Reviewer model gpt-6-astra (Codex Astra).

The initial review reproduced editing Draft while the wide inspector covered it. The corrected version removes covered controls from ordinary focus and closes the inspector before an explicit Selected Work or Draft shortcut transfers focus. The independent mounted Draft reproduction passed on this revision.

Reviewed saved-turn selection, response and request provenance, recorded-feedback disclosure, and the Transcript navigation fix. The existing wheel-consumer tests passed all eleven steps under Deno and Bun. No blocking findings.

taras commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

Independent review

PASS for 23fd0cb46395cff5c83af84daf83f25ff7ff5861 — Codex Astra.

  • The exchange and saved-turn inspectors link to entries admitted by the corresponding saved response. The existing entry navigation route closes the inspector and selects the entry.
  • Output precedes Saved Turns. Wrapped captions retain one keyboard stop per turn, and the 72-column drawer keeps its close, Escape, and paging controls. Covered Draft and Selected Work controls stay out of the wide inspector’s tab order.
  • An independent mounted probe passed at 120×30 and 72×20. It opened saved Turn 2, confirmed its recorded origin, and followed its link to Entry 1.

The reviewer evaluated correctness, minimalism, and performance for this exact commit.

taras commented Nov 15, 2026

Copy link
Copy Markdown
Owner Author

Independent review

PASS for d5a26f58a0fe6ba3c7659a50433f588d4760cb95 against b7d8fe283c1605a78eb5146bffbdc2c0525afbf5 — Codex Astra.

The reviewed REPL behavior and its acceptance journey are unchanged. The greetings test now checks the attributed [X] feedback and absence of raw control text before the later table changes the viewport. The review verified that the original source, output, receipt, and final-screen exclusions still apply. The focused tests passed under Deno and Bun, and the full affected journey passed on Node 22 (75 tests).

@taras
taras force-pushed the codex/repl-sidekick-inspection-931 branch from d5a26f5 to bc4d1f1 Compare November 16, 2026 00:19

taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Independent rebase review

PASS for bc4d1f19e6c160c0793d485f25790df5f720ea4b on 90d1cdb80e502d3f48f819a6403c3a2120ae419f — Codex Astra.

The net feature patch is byte-for-byte identical to the previously reviewed patch. All 13 feature files match. The new base contributes the wheel-burst fixture repair from #1345. The wheel-burst tests and the conversation cold-reopen journey passed locally on the rebased head.

@taras
taras marked this pull request as ready for review November 16, 2026 01:17
@taras
taras merged commit 85f9c85 into main Nov 16, 2026
65 checks passed
@taras
taras deleted the codex/repl-sidekick-inspection-931 branch November 16, 2026 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant