Skip to content

Run host REPL bench tests on main - #1348

Merged
taras merged 1 commit into
mainfrom
codex/repl-bench-on-main
Nov 16, 2026
Merged

taras merged 1 commit into
mainfrom
codex/repl-bench-on-main

Conversation

@taras

@taras taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

The REPL bench drives the real terminal on every pull request. On macOS, the Sidekick reopen journey can reach the narrow layout with Entries still selected because it requests a resize immediately after sending the tab click. The failing screen and an identical-commit retry are recorded in #1328.

What changes

Pull requests run the bench tool checks on Ubuntu. Pushes to main run the tool checks, PTY driver exit and teardown tests, and Markdown terminal journeys on Ubuntu and macOS. The required green check still includes the bench job. Terminal failure artifacts remain available on main.

The resize journey starts with focus in Draft, clicks Sidekick, and waits for the composer focus marker before resizing. It still checks the narrow viewport, screenshot, saved location, and reopened Sidekick view.

How to verify it

  • The workflow regression checks the host matrix and the jobs that own the bench tests on each event.
  • The PR bench tool command, the two PTY lifecycle tests, and all eight journeys in repl-bench.test.md passed locally on macOS.
  • With the click removed from a scratch copy, the journey fails at the composer focus checkpoint before resize.

Refs #1328.

Scope confirmation

  • Every changed file supports the purpose described above.
  • Unrelated cleanup and formatting changes are excluded.
  • The description matches the final diff and test results.

@taras
taras marked this pull request as ready for review November 16, 2026 00:58
@taras
taras merged commit 30d614c into main Nov 16, 2026
64 checks passed
@taras
taras deleted the codex/repl-bench-on-main branch November 16, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant