Repository navigation
Run host REPL bench tests on main - #1348
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The REPL bench drives the real terminal on every pull request. On macOS, the Sidekick reopen journey can reach the narrow layout with Entries still selected because it requests a resize immediately after sending the tab click. The failing screen and an identical-commit retry are recorded in #1328.
What changes
Pull requests run the bench tool checks on Ubuntu. Pushes to main run the tool checks, PTY driver exit and teardown tests, and Markdown terminal journeys on Ubuntu and macOS. The required green check still includes the bench job. Terminal failure artifacts remain available on main.
The resize journey starts with focus in Draft, clicks Sidekick, and waits for the composer focus marker before resizing. It still checks the narrow viewport, screenshot, saved location, and reopened Sidekick view.
How to verify it
repl-bench.test.mdpassed locally on macOS.Refs #1328.
Scope confirmation