Repository navigation
Wait for REPL bench actions to take effect - #1349
Merged
Merged
Conversation
Owner
Author
|
Independent review — PASS Codex Astra (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A terminal click can return before the REPL acts on it. The resize and recovery journeys sent dependent input after raw clicks or focus shortcuts, leaving the next input free to reach the previous view. The Sidekick resize failure is tracked in #1328.
What changes
The nine numbered focus components verify the destination is offered, send its digit once, and wait for the REPL to accept it. The Sidekick tab action waits for its composer to gain focus. The answer action waits for a visible answer control and verifies focus in the opened editor before the journey types.
All bench journeys that click the Sidekick tab or open its answer control use these components. The resize and reopen assertions still verify the result of the scenario. The modal shortcut test still sends raw input to verify the REPL refuses it.
How to verify it
xmd test examples/repl-bench/journeysfrom a prepared checkout. The focus journey checks that an unavailable shortcut fails and the original draft survives. The migrated resize and recovery journeys exercise the two new actions.deno test --allow-all --cached-only --frozen --node-modules-dir=none examples/repl-bench/tests. The screen tests include document text that resembles the focus legend.Refs #1328.
Scope confirmation