Skip to content

Wait for REPL bench actions to take effect - #1349

Merged
taras merged 1 commit into
mainfrom
codex/repl-bench-interactors
Nov 16, 2026
Merged

taras merged 1 commit into
mainfrom
codex/repl-bench-interactors

Conversation

@taras

@taras taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Why

A terminal click can return before the REPL acts on it. The resize and recovery journeys sent dependent input after raw clicks or focus shortcuts, leaving the next input free to reach the previous view. The Sidekick resize failure is tracked in #1328.

What changes

The nine numbered focus components verify the destination is offered, send its digit once, and wait for the REPL to accept it. The Sidekick tab action waits for its composer to gain focus. The answer action waits for a visible answer control and verifies focus in the opened editor before the journey types.

All bench journeys that click the Sidekick tab or open its answer control use these components. The resize and reopen assertions still verify the result of the scenario. The modal shortcut test still sends raw input to verify the REPL refuses it.

How to verify it

  • Run xmd test examples/repl-bench/journeys from a prepared checkout. The focus journey checks that an unavailable shortcut fails and the original draft survives. The migrated resize and recovery journeys exercise the two new actions.
  • Run deno test --allow-all --cached-only --frozen --node-modules-dir=none examples/repl-bench/tests. The screen tests include document text that resembles the focus legend.
  • The host terminal suite runs on pushes to main under Ubuntu and macOS. Local verification uses a macOS checkout whose path contains spaces.

Refs #1328.

Scope confirmation

  • Every changed file supports the purpose described above.
  • Unrelated cleanup and formatting changes are excluded.

@taras
taras marked this pull request as ready for review November 16, 2026 01:54
@taras
taras merged commit 635f864 into main Nov 16, 2026
64 checks passed
@taras
taras deleted the codex/repl-bench-interactors branch November 16, 2026 02:09

taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Independent review — PASS

Codex Astra (gpt-6-astra) reviewed commit 14d4ea75b88e8ff7ae7712cd0c264709fb96a335 and found no blocking issues.

  • The focus actions check that the shortcut is offered in the rendered terminal, send it once, and wait for the focus hints to close.
  • The Sidekick actions verify that activation moves focus to the composer and that opening an answer shows the answer editor.
  • The affected journeys use the shared actions. The modal test still sends raw keystrokes because it checks that the modal suppresses those inputs.
  • The added screen checks are bounded by the terminal viewport and use the existing wait mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant