Skip to content

Submit completed drafts for independent review and publish the verdict - #1350

Draft
taras wants to merge 8 commits into
mainfrom
codex/integration-delivery-review-1346
Draft

taras wants to merge 8 commits into
mainfrom
codex/integration-delivery-review-1346

Conversation

@taras

@taras taras commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Why

Independent review should run once the draft is ready for delivery. Planner and Architect feedback and CI repairs can change the draft several times before then.

This draft combines the comment publisher from #1324 with the delivery sequence in #1346 so the workflow can prove the whole path on a real PR targeting main.

What changes

Before, a new feedback commit could immediately make independent review the next action.

After, an explicit submission pins the green draft's exact SHA. Delivery retains the review on that SHA, publishes the validated verdict as a GitHub comment, and verifies its readback. The read-only ready action verifies the saved PASS and current green checks and reports the exact SHA for the maintainer to mark ready. A failed Fable attempt with recorded checkout movement holds before fallback. GitHub merge remains a separate action.

Review guide

Start with examples/adversarial-implementation/delivery.md. Trace admission through Delivery.Submit, the retained candidate through Delivery.Pin, and publication and readiness through Delivery.ReviewPublication and Delivery.Ready. The publisher and cadence changes are in separate signed commits.

How to verify it

  • Delivery.test.md exercises interim pushes, concurrent submissions, moved heads, repairs, and readiness.
  • DeliveryPublication.test.md exercises native comment readback, lost responses, and duplicate prevention.
  • This draft will exercise the real Codex Astra path after exact-head Planner and Architect feedback and green CI.

Scope confirmation

  • Each changed file supports publisher verification or delivery cadence.
  • The approved publisher and cadence changes are separately reviewable in the commit history.

@taras

taras commented Nov 16, 2026

Copy link
Copy Markdown
Owner Author

Independent review

Reviewed commit f86c8b0d108c13d822988abad3d6a02a53f300ff

Verdict PASS

Reviewer

codex / gpt-6-astra

Summary

Reviewed the exact commit against main 635f864bd5552d8a84803d4c17496b9f13e08c2c and all three clauses against the original readback-scope.md. No blocking correctness defects or material acceptance ambiguities found. Reused the supplied focused receipts and inspected their logs and affected consumers; no additional test execution was necessary. Source remained unchanged. All commands completed in the foreground; no processes remain outstanding.

Findings

Non-blocking

explicit-exact-submission: delivery.md routes dispatch through explicit Submit. Submit checks exact feedback, clean local SHA and branch, matching main-targeting open draft, and green CI, then reserves admission and rechecks gates. Attempt reservations prevent overlapping submissions from duplicating reviewer calls. The supplied Delivery journey and publication overlap evidence exercise these boundaries.

Non-blocking

pinned-verdict-repair: Pin, ReviewState and Reconcile retain the submitted revision, original assignment, joined outcome and source observations. Recorded primary source movement prevents Astra replacement; repeated submission cannot bypass the hold. Repair admission requires the prior changes-required verdict and verified comment plus fresh exact-head feedback and CI. Inspected moved-Fable and provider-continuity logs support the retained hold, stable-source fallback and recovery paths.

Non-blocking

verified-publication-ready: ReviewPublication and ReviewComment verify the rendered verdict and comment identity, reserve publication against duplicate writes, and adopt an existing matching comment without another reviewer call. Status refreshes local and remote gates after verifying a PASS comment; Ready consumes that same observation and performs no GitHub readiness mutation. The supplied readiness and Bun publication logs cover comment-lookup source movement, stable readiness, lost acknowledgements and concurrent publication. Maintainer readiness and merge remain separate.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant